summaryrefslogtreecommitdiffstats
path: root/nixos
diff options
context:
space:
mode:
authorAlyssa Ross <hi@alyssa.is>2023-12-05 13:20:36 +0100
committerAlyssa Ross <hi@alyssa.is>2023-12-14 02:08:16 +0100
commit59dc10b5a6f2a592af36375c68fda41246794b86 (patch)
tree805c78e1f4a71564b482a333c9b76c81e3187b75 /nixos
parent9bcf41fe0d9a517f3a141d78bf73c0dd8b7c3569 (diff)
nixos/users-groups: fix confusing error message
If we include users with unset groups, we get this very confusing message, with invalid Nix code: - The following users have a primary group that is undefined: qyliss Hint: Add this to your NixOS configuration: users.groups. = {}; We don't need to include such users in this check, since they'll be caught anyway by this one: - users.users.qyliss.group is unset. This used to default to nogroup, but this is unsafe. For example you can create a group for this user with: users.users.qyliss.group = "qyliss"; users.groups.qyliss = {};
Diffstat (limited to 'nixos')
-rw-r--r--nixos/modules/config/users-groups.nix2
1 files changed, 1 insertions, 1 deletions
diff --git a/nixos/modules/config/users-groups.nix b/nixos/modules/config/users-groups.nix
index 39aac9fb821b..2aed620eb154 100644
--- a/nixos/modules/config/users-groups.nix
+++ b/nixos/modules/config/users-groups.nix
@@ -475,7 +475,7 @@ let
sdInitrdUidsAreUnique = idsAreUnique (filterAttrs (n: u: u.uid != null) config.boot.initrd.systemd.users) "uid";
sdInitrdGidsAreUnique = idsAreUnique (filterAttrs (n: g: g.gid != null) config.boot.initrd.systemd.groups) "gid";
groupNames = lib.mapAttrsToList (n: g: g.name) cfg.groups;
- usersWithoutExistingGroup = lib.filterAttrs (n: u: !lib.elem u.group groupNames) cfg.users;
+ usersWithoutExistingGroup = lib.filterAttrs (n: u: u.group != "" && !lib.elem u.group groupNames) cfg.users;
spec = pkgs.writeText "users-groups.json" (builtins.toJSON {
inherit (cfg) mutableUsers;