diff options
| author | talyz <kim.lindberger@gmail.com> | 2021-06-04 14:48:00 +0200 |
|---|---|---|
| committer | talyz <kim.lindberger@gmail.com> | 2021-06-05 18:44:42 +0200 |
| commit | b7749c76715ba96727f7a12bc2514ddfa6847813 (patch) | |
| tree | a85f4684c53bd0ab4a35787fce95bf64edcce528 /nixos/lib/test-driver | |
| parent | f36a65f6e2e9f3641f12c7d6e48a5ec4b5c5394b (diff) | |
nixos/test-driver: Run commands with error handling
Bash's standard behavior of not propagating non-zero exit codes
through a pipeline is unexpected and almost universally
unwanted. Default to setting `pipefail` for the command being run;
it can still be turned off by prefixing the pipeline with
`set +o pipefail` if needed.
Also, set `errexit` and `nonunset` options to make the first command
of consecutive commands separated by `;` fail, and disallow
dereferencing unset variables respectively.
Diffstat (limited to 'nixos/lib/test-driver')
| -rw-r--r-- | nixos/lib/test-driver/test-driver.py | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/nixos/lib/test-driver/test-driver.py b/nixos/lib/test-driver/test-driver.py index e0e8b0fb71f4..ab739ce3222f 100644 --- a/nixos/lib/test-driver/test-driver.py +++ b/nixos/lib/test-driver/test-driver.py @@ -441,7 +441,7 @@ class Machine: def execute(self, command: str) -> Tuple[int, str]: self.connect() - out_command = "( {} ); echo '|!=EOF' $?\n".format(command) + out_command = "( set -euo pipefail; {} ); echo '|!=EOF' $?\n".format(command) self.shell.send(out_command.encode()) output = "" |