summaryrefslogtreecommitdiffstats
path: root/lib/fileset
diff options
context:
space:
mode:
authorSilvan Mosberger <silvan.mosberger@tweag.io>2023-10-02 18:49:50 +0200
committerSilvan Mosberger <silvan.mosberger@tweag.io>2023-10-04 16:31:14 +0200
commit5b4e53a30074a98621681142b4698f7c45ebc716 (patch)
tree25f2ffa0672fc7d6d7c19c196041c1cb83cd1d06 /lib/fileset
parent692b75257e415f46e477f473e65779b80a6e125c (diff)
lib.fileset: Don't use ulimit for testing tracing
Diffstat (limited to 'lib/fileset')
-rwxr-xr-xlib/fileset/tests.sh21
1 files changed, 13 insertions, 8 deletions
diff --git a/lib/fileset/tests.sh b/lib/fileset/tests.sh
index d1780af79e69..2dec97ab953d 100755
--- a/lib/fileset/tests.sh
+++ b/lib/fileset/tests.sh
@@ -689,18 +689,23 @@ rm -rf -- *
# `(all files in directory)` should only be used if there's at least one file (otherwise it would be `(empty)`)
# and this should be determined without doing a full search
#
-# Create a 100 level deep path, which would cause a stack overflow with the below limit
-# if recursed into to figure out if the current directory is empty
-mkdir -p "b/$(seq -s/ 100)"
-# But that can be avoided by short-circuiting if the file a (here intentionally ordered before b) is checked first.
+# a is intentionally ordered first here in order to allow triggering the short-circuit behavior
+# We then check that b is not read
# In a more realistic scenario, some directories might need to be recursed into,
# but a file would be quickly found to trigger the short-circuit.
touch a
-(
- # Locally limit the stack to 100 * 1024 bytes, this would cause a stack overflow if the short-circuiting isn't implemented
- ulimit -s 100
+mkdir b
+# We don't have lambda's in bash unfortunately,
+# so we just define a function instead and then pass its name
+# shellcheck disable=SC2317
+run() {
+ # This shouldn't read b/
expectTrace './.' "$work"' (all files in directory)'
-)
+ # Remove all files immediately after, triggering delete_self events for all of them
+ rmdir b
+}
+# Runs the function while checking that b isn't read
+withFileMonitor run b
rm -rf -- *
# Partially included directories trace entries as they are evaluated