summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorNicolas Werner <nicolas.werner@hotmail.de>2020-04-08 23:12:18 +0200
committerNicolas Werner <nicolas.werner@hotmail.de>2020-04-08 23:12:18 +0200
commit4fa12b52aad67f9500f036c96aa52cf8406e0cb6 (patch)
treed4985d2954ff17c0410c66d1ba45eb7d863060e5
parent6794b6472d3b447954df5d56e36f83f008fd0110 (diff)
Add comment on why we surpress some of those log messages
-rw-r--r--src/Logging.cpp18
1 files changed, 12 insertions, 6 deletions
diff --git a/src/Logging.cpp b/src/Logging.cpp
index f0c570a5..b63c2e5a 100644
--- a/src/Logging.cpp
+++ b/src/Logging.cpp
@@ -25,12 +25,18 @@ qmlMessageHandler(QtMsgType type, const QMessageLogContext &context, const QStri
const char *file = context.file ? context.file : "";
const char *function = context.function ? context.function : "";
- // Surpress binding wrning for now, as we can't set restore mode to keep compat with qt 5.10
- if (msg.endsWith(
- "QML Binding: Not restoring previous value because restoreMode has not been set.This "
- "behavior is deprecated.In Qt < 6.0 the default is Binding.RestoreBinding.In Qt >= "
- "6.0 the default is Binding.RestoreBindingOrValue.") ||
- msg.endsWith("Both point size and pixel size set. Using pixel size."))
+ if (
+ // Surpress binding wrning for now, as we can't set restore mode to keep compat with
+ // qt 5.10
+ msg.endsWith(
+ "QML Binding: Not restoring previous value because restoreMode has not been set.This "
+ "behavior is deprecated.In Qt < 6.0 the default is Binding.RestoreBinding.In Qt >= "
+ "6.0 the default is Binding.RestoreBindingOrValue.") ||
+ // The default style has the point size set. If you use pixel size anywhere, you get
+ // that warning, which is useless, since sometimes you need the pixel size to match the
+ // text to the size of the outer element for example. This is done in the avatar and
+ // without that you get one warning for every Avatar displayed, which is stupid!
+ msg.endsWith("Both point size and pixel size set. Using pixel size."))
return;
switch (type) {