summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorDaniel Calviño Sánchez <danxuliu@gmail.com>2022-02-16 13:24:33 +0100
committerDaniel Calviño Sánchez <danxuliu@gmail.com>2022-12-01 01:04:56 +0100
commit833c2f36b581a862ee9a8035bccefbe4abf6dc97 (patch)
tree7e17b2dfca472977b47ac5d20acd50ac768b8828
parentf411881aa8eec342638b9f6a14260e280e7c502a (diff)
Fix creating offers again in Firefox with disabled media and simulcastuse-renegotiations-to-update-publisher-connections
When a media track is disabled the track is nullified in the sender, so this needs to be taken into account when creating a new offer on an existing connection with disabled media (for example, to add a video track to a connection with an active but disabled audio track). Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
-rw-r--r--src/utils/webrtc/simplewebrtc/peer.js2
1 files changed, 1 insertions, 1 deletions
diff --git a/src/utils/webrtc/simplewebrtc/peer.js b/src/utils/webrtc/simplewebrtc/peer.js
index fea3aa592..210028f20 100644
--- a/src/utils/webrtc/simplewebrtc/peer.js
+++ b/src/utils/webrtc/simplewebrtc/peer.js
@@ -357,7 +357,7 @@ Peer.prototype.offer = function(options) {
if (sendVideo && this.enableSimulcast && adapter.browserDetails.browser === 'firefox') {
console.debug('Enabling Simulcasting for Firefox (RID)')
const sender = this.pc.getSenders().find(function(s) {
- return s.track.kind === 'video'
+ return s.track && s.track.kind === 'video'
})
if (sender) {
let parameters = sender.getParameters()