Merge pull request #135 from nextcloud-gmbh/fix/do-not-follow-your-own-account

exception when following yourself

2 files changed, 14 insertions, 0 deletions

diff --git a/lib/Exceptions/FollowSameAccountException.php b/lib/Exceptions/FollowSameAccountException.php
new file mode 100644
index 00000000..cdf5140a
--- /dev/null
+++ b/lib/Exceptions/FollowSameAccountException.php
@@ -0,0 +1,8 @@
+<?php
+
+namespace OCA\Social\Exceptions;
+
+class FollowSameAccountException extends \Exception {
+
+}
+
diff --git a/lib/Service/ActivityPub/FollowService.php b/lib/Service/ActivityPub/FollowService.php
index 4e9942af..bd802be5 100644
--- a/lib/Service/ActivityPub/FollowService.php
+++ b/lib/Service/ActivityPub/FollowService.php
@@ -36,6 +36,7 @@ use OCA\Social\Db\FollowsRequest;
 use OCA\Social\Exceptions\ActorDoesNotExistException;
 use OCA\Social\Exceptions\CacheActorDoesNotExistException;
 use OCA\Social\Exceptions\FollowDoesNotExistException;
+use OCA\Social\Exceptions\FollowSameAccountException;
 use OCA\Social\Exceptions\InvalidResourceException;
 use OCA\Social\Exceptions\RequestException;
 use OCA\Social\Exceptions\SocialAppConfigException;
@@ -121,9 +122,14 @@ class FollowService implements ICoreService {
 	 * @throws CacheActorDoesNotExistException
 	 * @throws InvalidResourceException
 	 * @throws UrlCloudException
+	 * @throws FollowSameAccountException
 	 */
 	public function followAccount(Person $actor, string $account) {
 		$remoteActor = $this->personService->getFromAccount($account);
+		if ($remoteActor->getId() === $actor->getId()) {
+			throw new FollowSameAccountException("Don't follow yourself, be your own lead");
+		}
+
 		$follow = new Follow();
 		$follow->setUrlCloud($this->configService->getCloudAddress());
 		$follow->generateUniqueId();