added pluggable fetchers

3 files changed, 156 insertions, 2 deletions

diff --git a/tests/bl/FeedBlTest.php b/tests/bl/FeedBlTest.php
index 9eee7eef1..9a9bd2002 100644
--- a/tests/bl/FeedBlTest.php
+++ b/tests/bl/FeedBlTest.php
@@ -36,7 +36,7 @@ use \OCA\AppFramework\Db\DoesNotExistException;
 
 use \OCA\News\Db\Feed;
 use \OCA\News\Db\Item;
-use \OCA\News\Utility\FeedFetcher;
+use \OCA\News\Utility\Fetcher;
 use \OCA\News\Utility\FetcherException;
 
 class FeedBlTest extends \OCA\AppFramework\Utility\TestUtility {
@@ -54,7 +54,7 @@ class FeedBlTest extends \OCA\AppFramework\Utility\TestUtility {
 		$this->mapper = $this->getMockBuilder('\OCA\News\Db\FeedMapper')
 			->disableOriginalConstructor()
 			->getMock();
-		$this->fetcher = $this->getMockBuilder('\OCA\News\Utility\FeedFetcher')
+		$this->fetcher = $this->getMockBuilder('\OCA\News\Utility\Fetcher')
 			->disableOriginalConstructor()
 			->getMock();
 		$this->itemMapper = $this->getMockBuilder('\OCA\News\Db\ItemMapper')
diff --git a/tests/utility/FeedFetcherTest.php b/tests/utility/FeedFetcherTest.php
new file mode 100644
index 000000000..0a1e2ed32
--- /dev/null
+++ b/tests/utility/FeedFetcherTest.php
@@ -0,0 +1,47 @@
+<?php
+
+/**
+* ownCloud - News
+*
+* @author Alessandro Cosentino
+* @author Bernhard Posselt
+* @copyright 2012 Alessandro Cosentino cosenal@gmail.com
+* @copyright 2012 Bernhard Posselt nukeawhale@gmail.com
+*
+* This library is free software; you can redistribute it and/or
+* modify it under the terms of the GNU AFFERO GENERAL PUBLIC LICENSE
+* License as published by the Free Software Foundation; either
+* version 3 of the License, or any later version.
+*
+* This library is distributed in the hope that it will be useful,
+* but WITHOUT ANY WARRANTY; without even the implied warranty of
+* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+* GNU AFFERO GENERAL PUBLIC LICENSE for more details.
+*
+* You should have received a copy of the GNU Affero General Public
+* License along with this library.  If not, see <http://www.gnu.org/licenses/>.
+*
+*/
+
+namespace OCA\News\Utility;
+
+require_once(__DIR__ . "/../classloader.php");
+
+
+class FeedFetcherTest extends \OCA\AppFramework\Utility\TestUtility {
+
+	private $fetcher;
+
+	protected function setUp(){
+		$this->fetcher = new FeedFetcher($this->getAPIMock());
+	}
+
+
+	public function testCanHandle(){
+		$url = 'google.de';
+
+		$this->assertTrue($this->fetcher->canHandle($url));
+	}
+
+	// TODO: write tests for the remaining methods
+}
\ No newline at end of file
diff --git a/tests/utility/FetcherTest.php b/tests/utility/FetcherTest.php
new file mode 100644
index 000000000..0da3b9265
--- /dev/null
+++ b/tests/utility/FetcherTest.php
@@ -0,0 +1,107 @@
+<?php
+
+/**
+* ownCloud - News
+*
+* @author Alessandro Cosentino
+* @author Bernhard Posselt
+* @copyright 2012 Alessandro Cosentino cosenal@gmail.com
+* @copyright 2012 Bernhard Posselt nukeawhale@gmail.com
+*
+* This library is free software; you can redistribute it and/or
+* modify it under the terms of the GNU AFFERO GENERAL PUBLIC LICENSE
+* License as published by the Free Software Foundation; either
+* version 3 of the License, or any later version.
+*
+* This library is distributed in the hope that it will be useful,
+* but WITHOUT ANY WARRANTY; without even the implied warranty of
+* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+* GNU AFFERO GENERAL PUBLIC LICENSE for more details.
+*
+* You should have received a copy of the GNU Affero General Public
+* License along with this library.  If not, see <http://www.gnu.org/licenses/>.
+*
+*/
+
+namespace OCA\News\Utility;
+
+require_once(__DIR__ . "/../classloader.php");
+
+
+class FetcherTest extends \OCA\AppFramework\Utility\TestUtility {
+
+	private $fetcher;
+
+	protected function setUp(){
+		$this->fetcher = new Fetcher();
+	}
+
+
+	public function testFetch(){
+		$url = 'hi';
+		$mockFetcher = $this->getMockBuilder('\OCA\News\Utility\IFeedFetcher')
+			->disableOriginalConstructor()
+			->getMock();
+		$mockFetcher->expects($this->once())
+			->method('canHandle')
+			->with($this->equalTo($url))
+			->will($this->returnValue(true));
+		$this->fetcher->registerFetcher($mockFetcher);
+
+		$this->fetcher->fetch($url);
+	}
+
+
+	public function testMultipleFetchers(){
+		$url = 'hi';
+		$mockFetcher = $this->getMockBuilder('\OCA\News\Utility\IFeedFetcher')
+			->disableOriginalConstructor()
+			->getMock();
+		$mockFetcher->expects($this->once())
+			->method('canHandle')
+			->with($this->equalTo($url))
+			->will($this->returnValue(false));
+		$mockFetcher2 = $this->getMockBuilder('\OCA\News\Utility\IFeedFetcher')
+			->disableOriginalConstructor()
+			->getMock();
+		$mockFetcher2->expects($this->once())
+			->method('canHandle')
+			->with($this->equalTo($url))
+			->will($this->returnValue(true));
+
+		$this->fetcher->registerFetcher($mockFetcher);
+		$this->fetcher->registerFetcher($mockFetcher2);
+
+		$this->fetcher->fetch($url);
+	}
+
+	public function testMultipleFetchersOnlyOneShouldHandle(){
+		$url = 'hi';
+		$return = 'zeas';
+		$mockFetcher = $this->getMockBuilder('\OCA\News\Utility\IFeedFetcher')
+			->disableOriginalConstructor()
+			->getMock();
+		$mockFetcher->expects($this->once())
+			->method('canHandle')
+			->with($this->equalTo($url))
+			->will($this->returnValue(true));
+		$mockFetcher->expects($this->once())
+			->method('fetch')
+			->with($this->equalTo($url))
+			->will($this->returnValue($return));
+		$mockFetcher2 = $this->getMockBuilder('\OCA\News\Utility\IFeedFetcher')
+			->disableOriginalConstructor()
+			->getMock();
+		$mockFetcher2->expects($this->never())
+			->method('canHandle');
+
+		$this->fetcher->registerFetcher($mockFetcher);
+		$this->fetcher->registerFetcher($mockFetcher2);
+
+		$result = $this->fetcher->fetch($url);
+
+		$this->assertEquals($return, $result);
+	}
+
+
+}
\ No newline at end of file