From 3350ed7cafa93873a6c0520e2bf0d9c05219adae Mon Sep 17 00:00:00 2001 From: Bernhard Posselt Date: Tue, 2 Apr 2013 11:09:33 +0200 Subject: added pluggable fetchers --- tests/bl/FeedBlTest.php | 4 +- tests/utility/FeedFetcherTest.php | 47 +++++++++++++++++ tests/utility/FetcherTest.php | 107 ++++++++++++++++++++++++++++++++++++++ 3 files changed, 156 insertions(+), 2 deletions(-) create mode 100644 tests/utility/FeedFetcherTest.php create mode 100644 tests/utility/FetcherTest.php (limited to 'tests') diff --git a/tests/bl/FeedBlTest.php b/tests/bl/FeedBlTest.php index 9eee7eef1..9a9bd2002 100644 --- a/tests/bl/FeedBlTest.php +++ b/tests/bl/FeedBlTest.php @@ -36,7 +36,7 @@ use \OCA\AppFramework\Db\DoesNotExistException; use \OCA\News\Db\Feed; use \OCA\News\Db\Item; -use \OCA\News\Utility\FeedFetcher; +use \OCA\News\Utility\Fetcher; use \OCA\News\Utility\FetcherException; class FeedBlTest extends \OCA\AppFramework\Utility\TestUtility { @@ -54,7 +54,7 @@ class FeedBlTest extends \OCA\AppFramework\Utility\TestUtility { $this->mapper = $this->getMockBuilder('\OCA\News\Db\FeedMapper') ->disableOriginalConstructor() ->getMock(); - $this->fetcher = $this->getMockBuilder('\OCA\News\Utility\FeedFetcher') + $this->fetcher = $this->getMockBuilder('\OCA\News\Utility\Fetcher') ->disableOriginalConstructor() ->getMock(); $this->itemMapper = $this->getMockBuilder('\OCA\News\Db\ItemMapper') diff --git a/tests/utility/FeedFetcherTest.php b/tests/utility/FeedFetcherTest.php new file mode 100644 index 000000000..0a1e2ed32 --- /dev/null +++ b/tests/utility/FeedFetcherTest.php @@ -0,0 +1,47 @@ +. +* +*/ + +namespace OCA\News\Utility; + +require_once(__DIR__ . "/../classloader.php"); + + +class FeedFetcherTest extends \OCA\AppFramework\Utility\TestUtility { + + private $fetcher; + + protected function setUp(){ + $this->fetcher = new FeedFetcher($this->getAPIMock()); + } + + + public function testCanHandle(){ + $url = 'google.de'; + + $this->assertTrue($this->fetcher->canHandle($url)); + } + + // TODO: write tests for the remaining methods +} \ No newline at end of file diff --git a/tests/utility/FetcherTest.php b/tests/utility/FetcherTest.php new file mode 100644 index 000000000..0da3b9265 --- /dev/null +++ b/tests/utility/FetcherTest.php @@ -0,0 +1,107 @@ +. +* +*/ + +namespace OCA\News\Utility; + +require_once(__DIR__ . "/../classloader.php"); + + +class FetcherTest extends \OCA\AppFramework\Utility\TestUtility { + + private $fetcher; + + protected function setUp(){ + $this->fetcher = new Fetcher(); + } + + + public function testFetch(){ + $url = 'hi'; + $mockFetcher = $this->getMockBuilder('\OCA\News\Utility\IFeedFetcher') + ->disableOriginalConstructor() + ->getMock(); + $mockFetcher->expects($this->once()) + ->method('canHandle') + ->with($this->equalTo($url)) + ->will($this->returnValue(true)); + $this->fetcher->registerFetcher($mockFetcher); + + $this->fetcher->fetch($url); + } + + + public function testMultipleFetchers(){ + $url = 'hi'; + $mockFetcher = $this->getMockBuilder('\OCA\News\Utility\IFeedFetcher') + ->disableOriginalConstructor() + ->getMock(); + $mockFetcher->expects($this->once()) + ->method('canHandle') + ->with($this->equalTo($url)) + ->will($this->returnValue(false)); + $mockFetcher2 = $this->getMockBuilder('\OCA\News\Utility\IFeedFetcher') + ->disableOriginalConstructor() + ->getMock(); + $mockFetcher2->expects($this->once()) + ->method('canHandle') + ->with($this->equalTo($url)) + ->will($this->returnValue(true)); + + $this->fetcher->registerFetcher($mockFetcher); + $this->fetcher->registerFetcher($mockFetcher2); + + $this->fetcher->fetch($url); + } + + public function testMultipleFetchersOnlyOneShouldHandle(){ + $url = 'hi'; + $return = 'zeas'; + $mockFetcher = $this->getMockBuilder('\OCA\News\Utility\IFeedFetcher') + ->disableOriginalConstructor() + ->getMock(); + $mockFetcher->expects($this->once()) + ->method('canHandle') + ->with($this->equalTo($url)) + ->will($this->returnValue(true)); + $mockFetcher->expects($this->once()) + ->method('fetch') + ->with($this->equalTo($url)) + ->will($this->returnValue($return)); + $mockFetcher2 = $this->getMockBuilder('\OCA\News\Utility\IFeedFetcher') + ->disableOriginalConstructor() + ->getMock(); + $mockFetcher2->expects($this->never()) + ->method('canHandle'); + + $this->fetcher->registerFetcher($mockFetcher); + $this->fetcher->registerFetcher($mockFetcher2); + + $result = $this->fetcher->fetch($url); + + $this->assertEquals($return, $result); + } + + +} \ No newline at end of file -- cgit v1.2.3