summaryrefslogtreecommitdiffstats
path: root/web
diff options
context:
space:
mode:
authorJacek Kolasa <jacek.kolasa@gmail.com>2019-12-05 13:41:15 +0100
committerGitHub <noreply@github.com>2019-12-05 13:41:15 +0100
commit7953472f1190b96c46ce3180c935bdcc9b5d2717 (patch)
tree78c4f8be754ec414010dad2d12badf247329c5de /web
parentf92a0924175b00ca3810f4b9d472b6f6bb96692d (diff)
address lgtm alerts (#7441)
Diffstat (limited to 'web')
-rw-r--r--web/gui/dash-example.html2
-rw-r--r--web/gui/main.js7
2 files changed, 5 insertions, 4 deletions
diff --git a/web/gui/dash-example.html b/web/gui/dash-example.html
index 231fec8cec..9de2316280 100644
--- a/web/gui/dash-example.html
+++ b/web/gui/dash-example.html
@@ -692,7 +692,7 @@ class PickNSort {
for (var i = 0; i < aProps.length; i++) {
var propName = aProps[i];
- var aa = a[propName]
+ var aa = a[propName];
var aaProps = Object.keys(aa);
var bb = b[propName];
var bbProps = Object.keys(bb);
diff --git a/web/gui/main.js b/web/gui/main.js
index 0635b07a7e..371ddca005 100644
--- a/web/gui/main.js
+++ b/web/gui/main.js
@@ -1818,7 +1818,7 @@ function renderPage(menus, data) {
if (!isMemoryModeDbEngine) {
sidebar += '<br />&nbsp;<br />Get more history by ' +
- '<a href="https://docs.netdata.cloud/docs/configuration-guide/#increase-the-metrics-retention-period" target=_blank>configuring Netdata\'s <strong>history</strong></a> or using the <a href="https://docs.netdata.cloud/database/engine/" target=_blank>DB engine.</a>'
+ '<a href="https://docs.netdata.cloud/docs/configuration-guide/#increase-the-metrics-retention-period" target=_blank>configuring Netdata\'s <strong>history</strong></a> or using the <a href="https://docs.netdata.cloud/database/engine/" target=_blank>DB engine.</a>';
}
sidebar += '<br/>&nbsp;<br/><strong>netdata</strong><br/>' + data.version.toString() + '</small></li>';
@@ -4956,7 +4956,8 @@ function handleSignInMessage(e) {
netdataRegistryCallback(registryAgents);
if (e.data.redirectURI && !window.location.href.includes(e.data.redirectURI)) {
- window.location.replace(e.data.redirectURI);
+ // lgtm false-positive - redirectURI does not come from user input, but from iframe callback
+ window.location.replace(e.data.redirectURI); // lgtm[js/client-side-unvalidated-url-redirection]
}
}
@@ -5183,5 +5184,5 @@ if (document.readyState === "complete") {
if (document.readyState === "complete") {
initializeApp();
}
- })
+ });
}