From 7953472f1190b96c46ce3180c935bdcc9b5d2717 Mon Sep 17 00:00:00 2001
From: Jacek Kolasa <jacek.kolasa@gmail.com>
Date: Thu, 5 Dec 2019 13:41:15 +0100
Subject: address lgtm alerts (#7441)

---
 web/gui/dash-example.html | 2 +-
 web/gui/main.js           | 7 ++++---
 2 files changed, 5 insertions(+), 4 deletions(-)

(limited to 'web')

diff --git a/web/gui/dash-example.html b/web/gui/dash-example.html
index 231fec8cec..9de2316280 100644
--- a/web/gui/dash-example.html
+++ b/web/gui/dash-example.html
@@ -692,7 +692,7 @@ class PickNSort {
 
 			for (var i = 0; i < aProps.length; i++) {
 				var propName = aProps[i];
-				var aa = a[propName]
+				var aa = a[propName];
 				var aaProps = Object.keys(aa);
 				var bb = b[propName];
 				var bbProps = Object.keys(bb);
diff --git a/web/gui/main.js b/web/gui/main.js
index 0635b07a7e..371ddca005 100644
--- a/web/gui/main.js
+++ b/web/gui/main.js
@@ -1818,7 +1818,7 @@ function renderPage(menus, data) {
 
     if (!isMemoryModeDbEngine) {
         sidebar += '<br />&nbsp;<br />Get more history by ' +
-          '<a href="https://docs.netdata.cloud/docs/configuration-guide/#increase-the-metrics-retention-period" target=_blank>configuring Netdata\'s <strong>history</strong></a> or using the <a href="https://docs.netdata.cloud/database/engine/" target=_blank>DB engine.</a>'
+          '<a href="https://docs.netdata.cloud/docs/configuration-guide/#increase-the-metrics-retention-period" target=_blank>configuring Netdata\'s <strong>history</strong></a> or using the <a href="https://docs.netdata.cloud/database/engine/" target=_blank>DB engine.</a>';
     }
 
     sidebar += '<br/>&nbsp;<br/><strong>netdata</strong><br/>' + data.version.toString() + '</small></li>';
@@ -4956,7 +4956,8 @@ function handleSignInMessage(e) {
 
     netdataRegistryCallback(registryAgents);
     if (e.data.redirectURI && !window.location.href.includes(e.data.redirectURI)) {
-        window.location.replace(e.data.redirectURI);
+        // lgtm false-positive - redirectURI does not come from user input, but from iframe callback
+        window.location.replace(e.data.redirectURI); // lgtm[js/client-side-unvalidated-url-redirection]
     }
 }
 
@@ -5183,5 +5184,5 @@ if (document.readyState === "complete") {
         if (document.readyState === "complete") {
             initializeApp();
         }
-    })
+    });
 }
-- 
cgit v1.2.3