diff options
| author | Costa Tsaousis <costa@tsaousis.gr> | 2018-10-30 02:35:57 +0200 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2018-10-30 02:35:57 +0200 |
| commit | 92327c9ec211bd1616315abcb255861b130b97ca (patch) | |
| tree | 1d22f965d3c7ccc34458b420579fb6d1e0004b24 /web/api | |
| parent | a35bd00fbf8f2578ec0c660b532e925911191b43 (diff) | |
fixed vulnerabilities identified by red4sec.com (#4521)
Diffstat (limited to 'web/api')
| -rw-r--r-- | web/api/web_api_v1.c | 17 |
1 files changed, 17 insertions, 0 deletions
diff --git a/web/api/web_api_v1.c b/web/api/web_api_v1.c index 0c0242c3ca..1e03828e40 100644 --- a/web/api/web_api_v1.c +++ b/web/api/web_api_v1.c @@ -233,6 +233,15 @@ inline int web_client_api_request_v1_chart(RRDHOST *host, struct web_client *w, return web_client_api_request_single_chart(host, w, url, rrd_stats_api_v1_chart); } +void fix_google_param(char *s) { + if(unlikely(!s)) return; + + for( ; *s ;s++) { + if(!isalnum(*s) && *s != '.' && *s != '_' && *s != '-') + *s = '_'; + } +} + // returns the HTTP code inline int web_client_api_request_v1_data(RRDHOST *host, struct web_client *w, char *url) { debug(D_WEB_CLIENT, "%llu: API v1 data with URL '%s'", w->id, url); @@ -332,6 +341,14 @@ inline int web_client_api_request_v1_data(RRDHOST *host, struct web_client *w, c } } + // validate the google parameters given + fix_google_param(google_out); + fix_google_param(google_sig); + fix_google_param(google_reqId); + fix_google_param(google_version); + fix_google_param(responseHandler); + fix_google_param(outFileName); + if(!chart || !*chart) { buffer_sprintf(w->response.data, "No chart id is given at the request."); goto cleanup; |