cmake missing defines (#16680)

* added HAVE_ACCEPT4

* added HAVE_FINITE, HAVE_ISFINITE

* added SIZEOF_VOID_P

* added HAVE_NICE, HAVE_RECVMMSG, HAVE_GETPRIORITY

* added HAVE_C__GENERIC

* added HAVE_C_MALLOPT

* added HAVE_BACKTRACE, HAVE_CLOSE_RANGE, HAVE_SCHED_GETSCHEDULER, HAVE_SCHED_SETSCHEDULER, HAVE_SCHED_GET_PRIORITY_MIN, HAVE_SCHED_GET_PRIORITY_MAX

* added HAVE_DLSYM

* added function attributes checks

* fix SIZEOF_VOID_P

* added HAVE_PTHREAD_GETNAME_NP

* fixed compiler warnings

6 files changed, 14 insertions, 8 deletions

diff --git a/libnetdata/datetime/rfc3339.c b/libnetdata/datetime/rfc3339.c
index 157e340d34..ac9f59597c 100644
--- a/libnetdata/datetime/rfc3339.c
+++ b/libnetdata/datetime/rfc3339.c
@@ -27,7 +27,7 @@ size_t rfc3339_datetime_ut(char *buffer, size_t len, usec_t now_ut, size_t fract
         return 0;
     }
 
-    if (fractional_digits >= 0 && fractional_digits <= 9) {
+    if (fractional_digits >= 1 && fractional_digits <= 9) {
         int fractional_part = (int)(now_ut % USEC_PER_SEC);
         if (fractional_part && len - used_length > fractional_digits + 1) {
             char format[] = ".%01d";
diff --git a/libnetdata/libnetdata.h b/libnetdata/libnetdata.h
index 36ba41b71b..0165750d04 100644
--- a/libnetdata/libnetdata.h
+++ b/libnetdata/libnetdata.h
@@ -28,6 +28,10 @@ extern "C" {
 #define NETDATA_INTERNAL_CHECKS 1
 #endif
 
+#ifndef SIZEOF_VOID_P
+#error SIZEOF_VOID_P is not defined
+#endif
+
 #if SIZEOF_VOID_P == 4
 #define ENV32BIT 1
 #else
diff --git a/libnetdata/log/log.c b/libnetdata/log/log.c
index bf63107756..bccab3f747 100644
--- a/libnetdata/log/log.c
+++ b/libnetdata/log/log.c
@@ -2112,7 +2112,7 @@ static void nd_logger(const char *file, const char *function, const unsigned lon
         else if(thread_log_fields[NDF_LOG_SOURCE].entry.type == NDFT_U64)
             src = thread_log_fields[NDF_LOG_SOURCE].entry.u64;
 
-        if(src != source && src >= 0 && src < _NDLS_MAX) {
+        if(src != source && src < _NDLS_MAX) {
             source = src;
             output = nd_logger_select_output(source, &fp, &spinlock);
             if(output != NDLM_FILE && output != NDLM_JOURNAL && output != NDLM_SYSLOG)
@@ -2396,7 +2396,8 @@ static bool nd_log_limit_reached(struct nd_log_source *source) {
                     source->limits.logs_per_period,
                     source->limits.throttle_period,
                     program_name,
-                    (int64_t)((source->limits.started_monotonic_ut + (source->limits.throttle_period * USEC_PER_SEC) - now_ut)) / USEC_PER_SEC);
+                    (int64_t)(((source->limits.started_monotonic_ut + (source->limits.throttle_period * USEC_PER_SEC) - now_ut)) / USEC_PER_SEC)
+            );
 
             if(source->pending_msg)
                 freez((void *)source->pending_msg);
diff --git a/libnetdata/log/systemd-cat-native.c b/libnetdata/log/systemd-cat-native.c
index ae946b04a1..0c89399d36 100644
--- a/libnetdata/log/systemd-cat-native.c
+++ b/libnetdata/log/systemd-cat-native.c
@@ -11,7 +11,7 @@
 #include <machine/endian.h>
 #endif
 
-static void log_message_to_stderr(BUFFER *msg) {
+static inline void log_message_to_stderr(BUFFER *msg) {
     CLEAN_BUFFER *tmp = buffer_create(0, NULL);
 
     for(size_t i = 0; i < msg->len ;i++) {
@@ -594,7 +594,7 @@ static int log_input_as_netdata(const char *newline, int timeout_ms) {
             // an empty line - we are done for this message
 
             nd_log(NDLS_HEALTH, priority,
-                   "added %d fields", // if the user supplied a MESSAGE, this will be ignored
+                   "added %zu fields", // if the user supplied a MESSAGE, this will be ignored
                    fields_added);
 
             lgs_reset(lgs);
@@ -627,7 +627,7 @@ static int log_input_as_netdata(const char *newline, int timeout_ms) {
 
                     nd_log(NDLS_COLLECTORS, NDLP_ERR,
                            "Field '%.*s' is not a Netdata field. Ignoring it.",
-                           field_len, field);
+                           (int)field_len, field);
 
                     lgs[NDF_MESSAGE] = backup;
                 }
@@ -648,7 +648,7 @@ static int log_input_as_netdata(const char *newline, int timeout_ms) {
     }
 
     if(fields_added) {
-        nd_log(NDLS_HEALTH, priority, "added %d fields", fields_added);
+        nd_log(NDLS_HEALTH, priority, "added %zu fields", fields_added);
         messages_logged++;
     }
 
diff --git a/libnetdata/query_progress/progress.c b/libnetdata/query_progress/progress.c
index b1fcbefd6a..350f6f3b02 100644
--- a/libnetdata/query_progress/progress.c
+++ b/libnetdata/query_progress/progress.c
@@ -636,6 +636,7 @@ int progress_unittest(void) {
         for(size_t i = 0; i < permanent ;i++) {
             qp = query_progress_find_in_hashtable_unsafe(&valid[i]);
             assert(qp);
+            (void)qp;
         }
     }
 
diff --git a/libnetdata/simple_hashtable.h b/libnetdata/simple_hashtable.h
index f21c01b151..af1b3cf31c 100644
--- a/libnetdata/simple_hashtable.h
+++ b/libnetdata/simple_hashtable.h
@@ -251,7 +251,7 @@ static void simple_hashtable_init_named(SIMPLE_HASHTABLE_NAMED *ht, size_t size)
     ht->hashtable = callocz(ht->size, sizeof(*ht->hashtable));
 }
 
-static void simple_hashtable_destroy_named(SIMPLE_HASHTABLE_NAMED *ht) {
+static inline void simple_hashtable_destroy_named(SIMPLE_HASHTABLE_NAMED *ht) {
 #ifdef SIMPLE_HASHTABLE_SORT_FUNCTION
     freez(ht->sorted.array);
 #endif