diff options
author | vkalintiris <vasilis@netdata.cloud> | 2022-05-03 19:02:36 +0300 |
---|---|---|
committer | GitHub <noreply@github.com> | 2022-05-03 19:02:36 +0300 |
commit | ebdd819d6ead44c5bab80c69be4a7d419402fe3c (patch) | |
tree | cb17c37c6febf067928d44203322d28e141a2aba /health | |
parent | ea451662055227545550d8f09deecb1427b7c672 (diff) |
Remove per chart configuration. (#12728)
After https://github.com/netdata/netdata/pull/12209 per-chart configuration
was used for (a) enabling/disabling a chart, and (b) renaming dimensions.
Regarding the first use case: We already have component-specific
configuration options|flags to finely control how a chart should behave.
Eg. "send charts matching" in streaming, "charts to skip from training"
in ML, etc. If we really need the concept of a disabled chart, we can
add a host-level simple pattern to match these charts.
Regarding the second use case: It's not obvious why we'd need to provide
support for remapping dimension names through a chart-specific configuration
from the core agent. If the need arises, we could add such support at
the right place, ie. a exporter/streaming config section.
This will allow each flag to act indepentendly from each other and
avoid managing flag-state manually at various places, eg:
```
if(unlikely(!rrdset_flag_check(st, RRDSET_FLAG_ENABLED))) {
rrdset_flag_clear(st, RRDSET_FLAG_UPSTREAM_SEND);
rrdset_flag_set(st, RRDSET_FLAG_UPSTREAM_IGNORE);
} ...
```
Diffstat (limited to 'health')
-rw-r--r-- | health/health.c | 5 |
1 files changed, 0 insertions, 5 deletions
diff --git a/health/health.c b/health/health.c index 912ddf6b26..c289e4b042 100644 --- a/health/health.c +++ b/health/health.c @@ -514,11 +514,6 @@ static inline int rrdcalc_isrunnable(RRDCALC *rc, time_t now, time_t *next_run) return 0; } - if(unlikely(!rrdset_flag_check(rc->rrdset, RRDSET_FLAG_ENABLED))) { - debug(D_HEALTH, "Health not running alarm '%s.%s'. The chart is not enabled", rc->chart?rc->chart:"NOCHART", rc->name); - return 0; - } - if(unlikely(rrdset_flag_check(rc->rrdset, RRDSET_FLAG_ARCHIVED))) { debug(D_HEALTH, "Health not running alarm '%s.%s'. The chart has been marked as archived", rc->chart?rc->chart:"NOCHART", rc->name); return 0; |