diff options
| author | Steven Hartland <steven.hartland@multiplay.co.uk> | 2019-10-17 14:35:08 +0100 |
|---|---|---|
| committer | Chris Akritidis <43294513+cakrit@users.noreply.github.com> | 2019-10-17 15:35:08 +0200 |
| commit | 7ff016ea74261246def5500308f17cb575059856 (patch) | |
| tree | fdb15a3a92ede70ffc41d74bddf4e64b740d7b30 /daemon/main.h | |
| parent | 4b9cc50adc5d3cd0a644ebbd2d5db4ae66e4208e (diff) | |
feat(reaper): Add process reaper support (#7059)
##### Summary
Add a child process reaper to the main netdata app if running as init (pid = 1).
This prevents zombie processes when a child is re-parented to netdata when its running in a container.
Also:
* Few style cleanups to match surrounding code.
Fixes: #6033
##### Component Name
netdata binary
##### Additional Information
This re-purposes old commented out code in `popen.c`, which already implemented part of the required process tracking.
Without this on a standard netdata docker install we saw at least one zombie `timeout` process straight after the container was started.
Diffstat (limited to 'daemon/main.h')
| -rw-r--r-- | daemon/main.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/daemon/main.h b/daemon/main.h index 687155981c..9d9f4ef0f5 100644 --- a/daemon/main.h +++ b/daemon/main.h @@ -41,7 +41,7 @@ struct netdata_static_thread { }; extern void cancel_main_threads(void); -extern int killpid(pid_t pid, int signal); +extern int killpid(pid_t pid); extern void netdata_cleanup_and_exit(int ret) NORETURN; extern void send_statistics(const char *action, const char *action_result, const char *action_data); |