diff options
| author | Markos Fountoulakis <44345837+mfundul@users.noreply.github.com> | 2019-09-24 11:59:15 +0300 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2019-09-24 11:59:15 +0300 |
| commit | 2728be8b0614fd58d4b530a32fee164509e88fd8 (patch) | |
| tree | abd39375b249b832327e35880597f9974be81b22 /daemon/global_statistics.c | |
| parent | 7977137cee3274d2535fbdb49ec2d68941285b82 (diff) | |
Detect deadlock in dbengine page cache (#6911)
* Detect deadlock in dbengine page cache when there are too many metrics and print error message
* Resolve dbengine deadlock by dropping metrics when page cache is too small and define relevant alarms
* Changed printing deadlock errors to only happen once per dbengine instance
Diffstat (limited to 'daemon/global_statistics.c')
| -rw-r--r-- | daemon/global_statistics.c | 9 |
1 files changed, 8 insertions, 1 deletions
diff --git a/daemon/global_statistics.c b/daemon/global_statistics.c index 53b7546f26..777ec2816a 100644 --- a/daemon/global_statistics.c +++ b/daemon/global_statistics.c @@ -538,7 +538,7 @@ void global_statistics_charts(void) { unsigned long long stats_array[RRDENG_NR_STATS]; /* get localhost's DB engine's statistics */ - rrdeng_get_33_statistics(localhost->rrdeng_ctx, stats_array); + rrdeng_get_35_statistics(localhost->rrdeng_ctx, stats_array); // ---------------------------------------------------------------- @@ -756,6 +756,8 @@ void global_statistics_charts(void) { static RRDSET *st_errors = NULL; static RRDDIM *rd_fs_errors = NULL; static RRDDIM *rd_io_errors = NULL; + static RRDDIM *rd_pg_cache_warnings = NULL; + static RRDDIM *rd_pg_cache_errors = NULL; if (unlikely(!st_errors)) { st_errors = rrdset_create_localhost( @@ -775,12 +777,17 @@ void global_statistics_charts(void) { rd_io_errors = rrddim_add(st_errors, "I/O errors", NULL, 1, 1, RRD_ALGORITHM_INCREMENTAL); rd_fs_errors = rrddim_add(st_errors, "FS errors", NULL, 1, 1, RRD_ALGORITHM_INCREMENTAL); + rd_pg_cache_warnings = rrddim_add(st_errors, "Page-Cache warnings", NULL, 1, 1, + RRD_ALGORITHM_INCREMENTAL); + rd_pg_cache_errors = rrddim_add(st_errors, "Page-Cache errors", NULL, 1, 1, RRD_ALGORITHM_INCREMENTAL); } else rrdset_next(st_errors); rrddim_set_by_pointer(st_errors, rd_io_errors, (collected_number)stats_array[30]); rrddim_set_by_pointer(st_errors, rd_fs_errors, (collected_number)stats_array[31]); + rrddim_set_by_pointer(st_errors, rd_pg_cache_warnings, (collected_number)stats_array[33]); + rrddim_set_by_pointer(st_errors, rd_pg_cache_errors, (collected_number)stats_array[34]); rrdset_done(st_errors); } |