[cleanup crusade] linting shell scripts for docker, tests and python (#4162)

* shell linting various scripts

* remove python-modules-installer.sh.in

1 files changed, 4 insertions, 4 deletions

diff --git a/coverity-scan.sh b/coverity-scan.sh
index 107690bc06..d39f9b246a 100755
--- a/coverity-scan.sh
+++ b/coverity-scan.sh
@@ -1,10 +1,10 @@
 #!/usr/bin/env bash
 
-cpus=$(grep ^processor </proc/cpuinfo| wc -l)
+cpus=$(grep -c ^processor </proc/cpuinfo)
 [ -z "${cpus}" ] && cpus=1
 
 token="${COVERITY_SCAN_TOKEN}"
-[ -z "${token}" -a -f .coverity-token ] && token="$(<.coverity-token)"
+([ -z "${token}" ] && [ -f .coverity-token ]) && token="$(<.coverity-token)"
 [ -z "${token}" ] && \
 	echo >&2 "Save the coverity token to .coverity-token or export it as COVERITY_SCAN_TOKEN." && \
 	exit 1
@@ -12,7 +12,7 @@ token="${COVERITY_SCAN_TOKEN}"
 # echo >&2 "Coverity token: ${token}"
 
 covbuild="$(which cov-build 2>/dev/null || command -v cov-build 2>/dev/null)"
-[ -z "${covbuild}" -a -f .coverity-build ] && covbuild="$(<.coverity-build)"
+([ -z "${covbuild}" ] && [ -f .coverity-build ]) && covbuild="$(<.coverity-build)"
 [ -z "${covbuild}" ] && \
 	echo "Save command the full filename of cov-build in .coverity-build" && \
 	exit 1
@@ -21,7 +21,7 @@ covbuild="$(which cov-build 2>/dev/null || command -v cov-build 2>/dev/null)"
 	echo "The command ${covbuild} is not executable. Save command the full filename of cov-build in .coverity-build" && \
 	exit 1
 
-version="$(cat config.h | grep "^#define PACKAGE_VERSION" | cut -d '"' -f 2)"
+version="$(grep "^#define PACKAGE_VERSION" config.h | cut -d '"' -f 2)"
 echo >&2 "Working on netdata version: ${version}"
 
 echo >&2 "Cleaning up old builds..."