remove the line length limit from pluginsd (#16013)pre-integrations-docs

* remove the line length limit from pluginsd

* initialize the buffer on every iteration

* buffer_tostring inlined

* Release buffer

---------

Co-authored-by: Stelios Fragkakis <52996999+stelfrag@users.noreply.github.com>

2 files changed, 13 insertions, 6 deletions

diff --git a/collectors/plugins.d/pluginsd_parser.c b/collectors/plugins.d/pluginsd_parser.c
index 82c36219a0..fbcd812627 100644
--- a/collectors/plugins.d/pluginsd_parser.c
+++ b/collectors/plugins.d/pluginsd_parser.c
@@ -2352,15 +2352,22 @@ inline size_t pluginsd_process(RRDHOST *host, struct plugind *cd, FILE *fp_plugi
     netdata_thread_cleanup_push(pluginsd_process_thread_cleanup, parser);
 
     buffered_reader_init(&parser->reader);
-    char buffer[PLUGINSD_LINE_MAX + 2];
+    BUFFER *buffer = buffer_create(sizeof(parser->reader.read_buffer) + 2, NULL);
     while(likely(service_running(SERVICE_COLLECTORS))) {
-        if (unlikely(!buffered_reader_next_line(&parser->reader, buffer, PLUGINSD_LINE_MAX + 2))) {
+        if (unlikely(!buffered_reader_next_line(&parser->reader, buffer))) {
             if(unlikely(!buffered_reader_read_timeout(&parser->reader, fileno((FILE *)parser->fp_input), 2 * 60 * MSEC_PER_SEC)))
                 break;
+
+            continue;
         }
-        else if(unlikely(parser_action(parser,  buffer)))
+
+        if(unlikely(parser_action(parser,  buffer->buffer)))
             break;
+
+        buffer->len = 0;
+        buffer->buffer[0] = '\0';
     }
+    buffer_free(buffer);
 
     cd->unsafe.enabled = parser->user.enabled;
     count = parser->user.data_collections_count;
diff --git a/collectors/plugins.d/pluginsd_parser.h b/collectors/plugins.d/pluginsd_parser.h
index 9fdb5846dd..74767569b9 100644
--- a/collectors/plugins.d/pluginsd_parser.h
+++ b/collectors/plugins.d/pluginsd_parser.h
@@ -154,8 +154,8 @@ static inline int parser_action(PARSER *parser, char *input) {
     parser->line++;
 
     if(unlikely(parser->flags & PARSER_DEFER_UNTIL_KEYWORD)) {
-        char command[PLUGINSD_LINE_MAX + 1];
-        bool has_keyword = find_first_keyword(input, command, PLUGINSD_LINE_MAX, isspace_map_pluginsd);
+        char command[100 + 1];
+        bool has_keyword = find_first_keyword(input, command, 100, isspace_map_pluginsd);
 
         if(!has_keyword || strcmp(command, parser->defer.end_keyword) != 0) {
             if(parser->defer.response) {
@@ -183,7 +183,7 @@ static inline int parser_action(PARSER *parser, char *input) {
         return 0;
     }
 
-    char *words[PLUGINSD_MAX_WORDS];
+    static __thread char *words[PLUGINSD_MAX_WORDS];
     size_t num_words = quoted_strings_splitter_pluginsd(input, words, PLUGINSD_MAX_WORDS);
     const char *command = get_word(words, num_words, 0);