diff options
| author | Ilya Mashchenko <ilya@netdata.cloud> | 2024-04-11 10:30:30 +0300 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2024-04-11 10:30:30 +0300 |
| commit | 2da14f9da4e46039859ce17481ad6f9b8e91aade (patch) | |
| tree | b5654b919e84c6ab8ab6640dcd60a1a4142293c6 | |
| parent | 95bf3c9d8db88cfe8c0315daaa27d52995b249b1 (diff) | |
go.d zfspool minor schema and meta fixes (#17372)
3 files changed, 9 insertions, 3 deletions
diff --git a/src/go/collectors/go.d.plugin/modules/intelgpu/intelgpu_test.go b/src/go/collectors/go.d.plugin/modules/intelgpu/intelgpu_test.go index 99ca604da0..8d897e2055 100644 --- a/src/go/collectors/go.d.plugin/modules/intelgpu/intelgpu_test.go +++ b/src/go/collectors/go.d.plugin/modules/intelgpu/intelgpu_test.go @@ -7,6 +7,8 @@ import ( "os" "testing" + "github.com/netdata/netdata/go/go.d.plugin/agent/module" + "github.com/stretchr/testify/assert" "github.com/stretchr/testify/require" ) @@ -28,6 +30,10 @@ func Test_testDataIsValid(t *testing.T) { } } +func TestIntelGPU_ConfigurationSerialize(t *testing.T) { + module.TestConfigurationSerialize(t, &IntelGPU{}, dataConfigJSON, dataConfigYAML) +} + func TestIntelGPU_Init(t *testing.T) { tests := map[string]struct { prepare func(igt *IntelGPU) diff --git a/src/go/collectors/go.d.plugin/modules/zfspool/config_schema.json b/src/go/collectors/go.d.plugin/modules/zfspool/config_schema.json index dc11055f00..fcfcff1d4c 100644 --- a/src/go/collectors/go.d.plugin/modules/zfspool/config_schema.json +++ b/src/go/collectors/go.d.plugin/modules/zfspool/config_schema.json @@ -15,14 +15,14 @@ "title": "Binary path", "description": "Path to the `zpool` binary.", "type": "string", - "default": "nvme" + "default": "/usr/bin/zpool" }, "timeout": { "title": "Timeout", "description": "Timeout for executing the binary, specified in seconds.", "type": "number", "minimum": 0.5, - "default": 10 + "default": 2 } }, "required": [ diff --git a/src/go/collectors/go.d.plugin/modules/zfspool/metadata.yaml b/src/go/collectors/go.d.plugin/modules/zfspool/metadata.yaml index e82611be4f..847ee483e4 100644 --- a/src/go/collectors/go.d.plugin/modules/zfspool/metadata.yaml +++ b/src/go/collectors/go.d.plugin/modules/zfspool/metadata.yaml @@ -82,7 +82,7 @@ modules: alerts: - name: zfs_pool_space_utilization metric: zfspool.pool_space_utilization - info: "ZFS pool **${label:pool}** is nearing capacity. Current space usage is above the threshold." + info: "ZFS pool ${label:pool} is nearing capacity. Current space usage is above the threshold." link: https://github.com/netdata/netdata/blob/master/src/health/health.d/zfs.conf - name: zfs_pool_health_state_warn metric: zfspool.pool_health_state |