Improve mutt_decrease_mtime() error handling.

Add a check for utime failure.  Some non-posix implementations return
EINTR.  Since editing messages is a very common operation in Mutt,
take care to retry in that case so as not to introduce message
composition failures.

Make sure all callers check mutt_decrease_mtime()'s return value,
since stat could also fail.

1 files changed, 5 insertions, 0 deletions

diff --git a/headers.c b/headers.c
index e1af1d9e..a3d36fc1 100644
--- a/headers.c
+++ b/headers.c
@@ -77,6 +77,11 @@ int mutt_edit_headers (const char *editor,
     }
 
     sctx->tempfile_mtime = mutt_decrease_mtime (mutt_b2s (sctx->tempfile), &st);
+    if (sctx->tempfile_mtime == (time_t) -1)
+    {
+      mutt_perror (mutt_b2s (sctx->tempfile));
+      goto cleanup;
+    }
 
     if (flags == MUTT_EDIT_HEADERS_BACKGROUND)
     {