Improve mutt_decrease_mtime() error handling.

Add a check for utime failure.  Some non-posix implementations return
EINTR.  Since editing messages is a very common operation in Mutt,
take care to retry in that case so as not to introduce message
composition failures.

Make sure all callers check mutt_decrease_mtime()'s return value,
since stat could also fail.

1 files changed, 6 insertions, 1 deletions

diff --git a/editmsg.c b/editmsg.c
index 82437cb2..384f5d6b 100644
--- a/editmsg.c
+++ b/editmsg.c
@@ -123,7 +123,12 @@ static int edit_one_message (CONTEXT *ctx, HEADER *cur)
     goto bail;
   }
 
-  mtime = mutt_decrease_mtime (mutt_b2s (tmp), &sb);
+  if ((mtime = mutt_decrease_mtime (mutt_b2s (tmp), &sb)) == (time_t) -1)
+  {
+    rc = -1;
+    mutt_perror (mutt_b2s (tmp));
+    goto bail;
+  }
 
   mutt_edit_file (NONULL(Editor), mutt_b2s (tmp));