1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
|
#include <gtest/gtest.h>
#include "track/trackmetadatataglib.h"
#include "util/memory.h"
#include <taglib/tstring.h>
#include <taglib/textidentificationframe.h>
#include <QtDebug>
namespace {
class MetadataTest : public testing::Test {
protected:
double parseBpm(QString inputValue, bool expectedResult, double expectedValue) {
//qDebug() << "parseBpm" << inputValue << expectedResult << expectedValue;
bool actualResult;
const double actualValue = mixxx::Bpm::valueFromString(inputValue, &actualResult);
EXPECT_EQ(expectedResult, actualResult);
EXPECT_DOUBLE_EQ(expectedValue, actualValue);
// if (actualResult) {
// qDebug() << "BPM:" << inputValue << "->" << mixxx::Bpm::valueToString(actualValue);
// }
return actualResult;
}
void normalizeBpm(double normalizedValue) {
mixxx::Bpm normalizedBpm(normalizedValue);
normalizedBpm.normalizeValue(); // re-normalize
// Expected: Re-normalization does not change the value
// that should already be normalized.
EXPECT_EQ(normalizedBpm.getValue(), normalizedValue);
}
void readBPMFromId3(const char* inputValue, double expectedValue) {
TagLib::ID3v2::Tag tag;
tag.header()->setMajorVersion(3);
auto pFrame =
std::make_unique<TagLib::ID3v2::TextIdentificationFrame>("TBPM", TagLib::String::Latin1);
pFrame->setText(TagLib::String(inputValue, TagLib::String::UTF8));
tag.addFrame(pFrame.get());
// Now that the plain pointer in pFrame is owned and managed by
// pTag we need to release the ownership to avoid double deletion!
pFrame.release();
mixxx::TrackMetadata trackMetadata;
mixxx::taglib::readTrackMetadataFromID3v2Tag(&trackMetadata, tag);
EXPECT_DOUBLE_EQ(expectedValue,trackMetadata.getBpm().getValue());
}
};
TEST_F(MetadataTest, ParseBpmPrecision) {
parseBpm("128.1234", true, 128.1234); // 4 fractional digits
//Test special case where BPM value represents cents of a BPM (like 1240 instead of 124)
const char* bpmchar[] = {
"200",
"600",
"1256",
"14525"
};
double bpmdouble[] = {
200.0,
60.0,
125.6,
145.25
};
for (size_t i = 0; i < sizeof(bpmchar) / sizeof(bpmchar[0]); ++i) {
readBPMFromId3(bpmchar[i], bpmdouble[i]);
}
}
TEST_F(MetadataTest, ParseBpmValidRange) {
for (int bpm100 = int(mixxx::Bpm::kValueMin) * 100; mixxx::Bpm::kValueMax * 100 >= bpm100; ++bpm100) {
const double expectedValue = bpm100 / 100.0;
const QString inputValues[] = {
QString("%1").arg(expectedValue),
QString(" %1 ").arg(expectedValue),
};
for (size_t i = 0; i < sizeof(inputValues) / sizeof(inputValues[0]); ++i) {
parseBpm(inputValues[i], true, expectedValue);
}
}
}
TEST_F(MetadataTest, ParseBpmInvalid) {
parseBpm("", false, mixxx::Bpm::kValueUndefined);
parseBpm("abcde", false, mixxx::Bpm::kValueUndefined);
parseBpm("0 dBA", false, mixxx::Bpm::kValueUndefined);
}
TEST_F(MetadataTest, NormalizeBpm) {
normalizeBpm(mixxx::Bpm::kValueUndefined);
normalizeBpm(mixxx::Bpm::kValueMin);
normalizeBpm(mixxx::Bpm::kValueMin - 1.0);
normalizeBpm(mixxx::Bpm::kValueMin + 1.0);
normalizeBpm(-mixxx::Bpm::kValueMin);
normalizeBpm(mixxx::Bpm::kValueMax);
normalizeBpm(mixxx::Bpm::kValueMax - 1.0);
normalizeBpm(mixxx::Bpm::kValueMax + 1.0);
normalizeBpm(-mixxx::Bpm::kValueMax);
}
TEST_F(MetadataTest, ID3v2Year) {
const char* kYears[] = {
" 1987 ",
" 2001-01-01",
"1997-12", // yyyy-MM
"1977-W43", // year + week
"2002 -12 - 31 ",
"2015 -02 - 04T 18:43",
"2015 -02 - 04 18:43",
"2015 -02 - 04 18:43 followed by arbitrary text"
};
// Only ID3v2.3.0 and ID3v2.4.0 are supported for writing
for (int majorVersion = 3; 4 >= majorVersion; ++majorVersion) {
qDebug() << "majorVersion" << majorVersion;
for (size_t i = 0; i < sizeof(kYears) / sizeof(kYears[0]); ++i) {
const QString year(kYears[i]);
TagLib::ID3v2::Tag tag;
tag.header()->setMajorVersion(majorVersion);
{
mixxx::TrackMetadata trackMetadata;
trackMetadata.setYear(year);
mixxx::taglib::writeTrackMetadataIntoID3v2Tag(&tag, trackMetadata);
}
mixxx::TrackMetadata trackMetadata;
mixxx::taglib::readTrackMetadataFromID3v2Tag(&trackMetadata, tag);
if (4 > majorVersion) {
// ID3v2.3.0: parsed + formatted
const QString actualYear(trackMetadata.getYear());
const QDate expectedDate(mixxx::TrackMetadata::parseDate(year));
if (expectedDate.isValid()) {
// Only the date part can be stored in an ID3v2.3.0 tag
EXPECT_EQ(mixxx::TrackMetadata::formatDate(expectedDate), actualYear);
} else {
// numeric year (without month/day)
EXPECT_EQ(mixxx::TrackMetadata::reformatYear(year), actualYear);
}
} else {
// ID3v2.4.0: currently unverified/unmodified
EXPECT_EQ(year, trackMetadata.getYear());
}
}
}
}
TEST_F(MetadataTest, CalendarYear) {
// Parsing
EXPECT_EQ(2014, mixxx::TrackMetadata::parseCalendarYear("2014-04-29T07:00:00Z"));
EXPECT_EQ(2014, mixxx::TrackMetadata::parseCalendarYear("2014-04-29"));
EXPECT_EQ(2014, mixxx::TrackMetadata::parseCalendarYear("2014"));
EXPECT_EQ(2015, mixxx::TrackMetadata::parseCalendarYear("2015-02"));
EXPECT_EQ(1997, mixxx::TrackMetadata::parseCalendarYear("1997-W43"));
EXPECT_EQ(1, mixxx::TrackMetadata::parseCalendarYear("1"));
EXPECT_EQ(mixxx::TrackMetadata::kCalendarYearInvalid, mixxx::TrackMetadata::parseCalendarYear("0"));
EXPECT_EQ(mixxx::TrackMetadata::kCalendarYearInvalid, mixxx::TrackMetadata::parseCalendarYear("-1"));
EXPECT_EQ(mixxx::TrackMetadata::kCalendarYearInvalid, mixxx::TrackMetadata::parseCalendarYear("year"));
// Formatting
EXPECT_EQ("2014", mixxx::TrackMetadata::formatCalendarYear("2014-04-29T07:00:00Z"));
EXPECT_EQ("2014", mixxx::TrackMetadata::formatCalendarYear("2014-04-29"));
EXPECT_EQ("2014", mixxx::TrackMetadata::formatCalendarYear("2014"));
EXPECT_EQ("2015", mixxx::TrackMetadata::formatCalendarYear("2015-02"));
EXPECT_EQ("1997", mixxx::TrackMetadata::formatCalendarYear("1997-W43"));
EXPECT_EQ("", mixxx::TrackMetadata::formatCalendarYear("0"));
EXPECT_EQ("", mixxx::TrackMetadata::formatCalendarYear("-1"));
EXPECT_EQ("", mixxx::TrackMetadata::formatCalendarYear("year"));
}
} // namespace
|
