1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
|
#include <gtest/gtest.h>
#include <QDir>
#include <QUrl>
#include <QScopedPointer>
#include <QtDebug>
#include "controllers/controller.h"
#include "controllers/controllerpresetfilehandler.h"
#include "controllers/controllerpresetinfoenumerator.h"
#include "controllers/midi/midicontrollerpreset.h"
#include "controllers/hid/hidcontrollerpreset.h"
#include "controllers/defs_controllers.h"
#include "test/mixxxtest.h"
class FakeController : public Controller {
public:
FakeController();
~FakeController() override;
QString presetExtension() override {
// Doesn't affect anything at the moment.
return ".test.xml";
}
ControllerPresetPointer getPreset() const override {
if (m_bHidPreset) {
HidControllerPreset* pClone = new HidControllerPreset();
*pClone = m_hidPreset;
return ControllerPresetPointer(pClone);
} else {
MidiControllerPreset* pClone = new MidiControllerPreset();
*pClone = m_midiPreset;
return ControllerPresetPointer(pClone);
}
}
bool savePreset(const QString fileName) const override {
Q_UNUSED(fileName);
return true;
}
void visit(const MidiControllerPreset* preset) override {
m_bMidiPreset = true;
m_bHidPreset = false;
m_midiPreset = *preset;
m_hidPreset = HidControllerPreset();
}
void visit(const HidControllerPreset* preset) override {
m_bMidiPreset = false;
m_bHidPreset = true;
m_midiPreset = MidiControllerPreset();
m_hidPreset = *preset;
}
void accept(ControllerVisitor* visitor) override {
// Do nothing since we aren't a normal controller.
Q_UNUSED(visitor);
}
bool isMappable() const override {
if (m_bMidiPreset) {
return m_midiPreset.isMappable();
} else if (m_bHidPreset) {
return m_hidPreset.isMappable();
}
return false;
}
bool matchPreset(const PresetInfo& preset) override {
// We're not testing product info matching in this test.
Q_UNUSED(preset);
return false;
}
protected:
Q_INVOKABLE void send(QList<int> data, unsigned int length, unsigned int reportID) {
Q_UNUSED(data);
Q_UNUSED(length);
Q_UNUSED(reportID);
}
private slots:
int open() override {
return 0;
}
int close() override {
return 0;
}
private:
void send(QByteArray data) override {
Q_UNUSED(data);
}
virtual void send(QByteArray data, unsigned int reportID) {
Q_UNUSED(data);
Q_UNUSED(reportID);
}
ControllerPreset* preset() override {
if (m_bHidPreset) {
return &m_hidPreset;
} else {
// Default to MIDI.
return &m_midiPreset;
}
}
bool m_bMidiPreset;
bool m_bHidPreset;
MidiControllerPreset m_midiPreset;
HidControllerPreset m_hidPreset;
};
FakeController::FakeController()
: m_bMidiPreset(false),
m_bHidPreset(false) {
}
FakeController::~FakeController() {
}
class ControllerPresetValidationTest : public MixxxTest {
protected:
void SetUp() override {
m_presetPaths << QDir::currentPath() + "/res/controllers";
m_pEnumerator.reset(new PresetInfoEnumerator(m_presetPaths));
}
bool testLoadPreset(const PresetInfo& preset) {
ControllerPresetPointer pPreset =
ControllerPresetFileHandler::loadPreset(preset.getPath(),
m_presetPaths);
if (pPreset.isNull()) {
return false;
}
FakeController controller;
controller.setDeviceName("Test Controller");
controller.startEngine();
controller.setPreset(*pPreset);
// Do not initialize the scripts.
bool result = controller.applyPreset(m_presetPaths, false);
controller.stopEngine();
return result;
}
QStringList m_presetPaths;
QScopedPointer<PresetInfoEnumerator> m_pEnumerator;
};
bool checkUrl(const QString& url) {
return QUrl(url).isValid();
}
bool lintPresetInfo(const PresetInfo& preset) {
bool result = true;
if (preset.getName().trimmed().isEmpty()) {
qWarning() << "LINT:" << preset.getPath() << "has no name.";
result = false;
}
if (preset.getAuthor().trimmed().isEmpty()) {
qWarning() << "LINT:" << preset.getPath() << "has no author.";
}
if (preset.getDescription().trimmed().isEmpty()) {
qWarning() << "LINT:" << preset.getPath() << "has no description.";
}
if (preset.getForumLink().trimmed().isEmpty()) {
qWarning() << "LINT:" << preset.getPath() << "has no forum link.";
} else if (!checkUrl(preset.getForumLink())) {
qWarning() << "LINT:" << preset.getPath() << "has invalid forum link";
result = false;
}
if (preset.getWikiLink().trimmed().isEmpty()) {
qWarning() << "LINT:" << preset.getPath() << "has no wiki link.";
} else if (!checkUrl(preset.getWikiLink())) {
qWarning() << "LINT:" << preset.getPath() << "has invalid wiki link";
result = false;
}
return result;
}
TEST_F(ControllerPresetValidationTest, MidiPresetsValid) {
foreach (const PresetInfo& preset,
m_pEnumerator->getPresetsByExtension(MIDI_PRESET_EXTENSION)) {
qDebug() << "Validating" << preset.getPath();
EXPECT_TRUE(preset.isValid());
EXPECT_TRUE(lintPresetInfo(preset));
EXPECT_TRUE(testLoadPreset(preset));
}
}
TEST_F(ControllerPresetValidationTest, HidPresetsValid) {
foreach (const PresetInfo& preset,
m_pEnumerator->getPresetsByExtension(HID_PRESET_EXTENSION)) {
qDebug() << "Validating" << preset.getPath();
EXPECT_TRUE(preset.isValid());
EXPECT_TRUE(lintPresetInfo(preset));
EXPECT_TRUE(testLoadPreset(preset));
}
}
TEST_F(ControllerPresetValidationTest, BulkPresetsValid) {
foreach (const PresetInfo& preset,
m_pEnumerator->getPresetsByExtension(BULK_PRESET_EXTENSION)) {
qDebug() << "Validating" << preset.getPath();
EXPECT_TRUE(preset.isValid());
EXPECT_TRUE(lintPresetInfo(preset));
EXPECT_TRUE(testLoadPreset(preset));
}
}
|
