summaryrefslogtreecommitdiffstats
path: root/src/waveform
AgeCommit message (Collapse)Author
2020-07-12Merge pull request #2712 from JosepMaJAZ/windows-installer-fixesBe
Windows CMake installer improvements
2020-07-12Corrections to the doc installation path (CMake)JosepMaJAZ
Inclusion of the current QT 5 translation files (CMake and Scons) Corrected one resource path in glslwaveformrenderersignal.cpp Cleaned mixxx.qrc
2020-07-12Delete redundant explicit static_castUwe Klotz
2020-07-12Fix crash in ~GLSLWaveformWidget()Uwe Klotz
2020-06-11Make QString m_group constDaniel Schürmann
2020-06-10Get rid of char group stringsDaniel Schürmann
For accessing control objects we need QStrings and converting them on the fly takes some unnecassary time.
2020-06-05Avoid copy in range-based for loopUwe Klotz
2020-06-04Use chars instead of single-char strings for QString::split()Jan Holthuis
2020-06-04Replace QString::SkipEmptyParts with Qt::SkipEmptyPartsJan Holthuis
2020-06-03Merge pull request #2822 from Holzhaus/qt5-15-warningsDaniel Schürmann
Fix some Qt 5.15 deprecation warnings
2020-06-01Merge pull request #2792 from daschuer/valgrindUwe Klotz
Valgrind fixes
2020-05-28Make QFlags usage type-safe and use default contructorJan Holthuis
2020-05-16Initalize m_configTypeDaniel Schürmann
2020-05-16Don't use a non const references in WaveformWidgetFactory::setWidgetType()Daniel Schürmann
2020-05-16convert to const methodsHarshit Maurya
2020-05-16rename variables and change commentsHarshit Maurya
2020-05-16waveformmark: add function to detect point in markHarshit Maurya
2020-05-16waveformrendermark: cleaner rectangle initialisationHarshit Maurya
2020-05-16wwaveformviewer: highlight hovered markHarshit Maurya
2020-05-16remove redundant inlinesHarshit Maurya
2020-05-16waveformwidgetrenderer: remove std::optional wrappingHarshit Maurya
2020-05-16wwaveformviewer: detect right click in mark line vicinityHarshit Maurya
2020-05-16wwaveformrendermark: remove unnecessary state variableHarshit Maurya
2020-05-16wwaveformviewer: add menu to vertical orientationHarshit Maurya
2020-05-16wwaveformviewer: limit to cue markers on screenHarshit Maurya
2020-05-16wwaveformviewer: add context menu to scrolling waveformHarshit Maurya
2020-05-06waveform/renderers/waveformmarkset: Draw hotcue mark with lowest index on topJan Holthuis
Currently, hotcue marks on the same position are drawn over each other and only the hotcue mark with the highest index is shown. Since not all hotcue indices might be mapped on the controller (or accessible via the skin) it makes sense to draw mark with the lowest index on top to increase the chance that a user can jump to it via GUI or performance pads. Zulip Discussion: https://mixxx.zulipchat.com/#narrow/stream/109171-development/topic/hotcue.20markers.20drawn.20over.20each.20other
2020-05-04Move Beats et al. to mixxx namespaceJavier Vilarroig
2020-05-02Merge pull request #2651 from JosepMaJAZ/GL_Qt514_windows-fixBe
Bugfix for GL waveforms with QT 5.14 on Windows.
2020-04-28Fix various typosluz.paz
Found via codespell v1.17.0.dev0 ``` codespell -q 3 -S *.ts,*.po,*.rtf,./.git,./src/library,./lib,./build/wix -L ba,chang,ect,everytime,german,hace,iff,jus,ith,lokal,nd,ons,pevent,pparent,preverse,seeked,sheat,sinc,splitted,substract,thru,tim,uint ```
2020-04-26fix commentJosep Maria Antolín Segura
Co-Authored-By: Be <be.0@gmx.com>
2020-04-24Added ifdefs for QT version and OS as suggested in the PR, plus some other ↵JosepMaJAZ
suggestions.
2020-04-24Removed makeCurrent() from QGLWidget destructors:JosepMaJAZ
Other gl waveforms don't have it, and it crashed on Mixxx close when I tested glsimplewaveformwidget because currentContext() (or was it context()?) was null Also added makeCurrent() to qthsvwaveformwidget constructor, which was missing.
2020-04-18Improving commentsJosep Maria Antolín Segura
Co-Authored-By: Jan Holthuis <holthuis.jan@googlemail.com>
2020-04-18Improving commentsJosep Maria Antolín Segura
Co-Authored-By: Jan Holthuis <holthuis.jan@googlemail.com>
2020-04-18Merge branch 'master' into GL_Qt514_windows-fixJosepMaJAZ
2020-04-15Merge pull request #2616 from ronso0/passthrough-coverJan Holthuis
show Passthrough cover on track overview
2020-04-14draw passthrough overlay on overview waveformronso0
When vinyl passthrough is enabled, dimm waveform overviews with a translucent overlay on top of all overview itemsgraphics and put 'Passthrough' QLabel on top. Any mouse events are still passed to the overview widget. Skin style: The cover color is picked from skin node <PassthroughOverlayColor> in the Overview widget (default #bb000000), the default label style can be adjusted in qss (#PassthroughLabel).
2020-04-12Fixes from the PR (naming , doxygen and spaces)JosepMaJAZ
2020-04-12Fixes from the PR (naming , doxygen and spaces)JosepMaJAZ
2020-04-11Bugfix for GL waveforms with QT 5.14 on Windows.JosepMaJAZ
2020-04-10WaveformRenderMark: fix hotcues getting shifted to the rightBe
Commit f024e7587f9b30a0890cb7e497d55bc3ef137f28 (from GitHub PR #2529) changed hotcue creation so hotcues are labelled with a null default constructed QString instead of an empty string by default. This triggered a legacy code path in WaveformRenderMark::generateMarkImage which is no longer needed. This commit deletes the legacy code path and renders all cue images using the same drawing code regardless of whether their label string is empty. fixes https://bugs.launchpad.net/mixxx/+bug/1870942
2020-02-29Migrate hotcue color logic to mixxx::RgbColorJan Holthuis
2020-02-28Remove PredefinedColorRepresentationFerran Pujol Camins
2020-02-28Make Cue related code use QColor instead of PredefinedColorPointerFerran Pujol Camins
COs and the database now hold the color hex int representation instead of a color id.
2020-02-20Don't use a undocumentated Qt header file (changed in QT 5.8)Daniel Schürmann
2020-02-16use #pragma once anf move the GL check to the very top of the filesDaniel Schürmann
2020-02-16Make Mixxx compile even though QT_NO_OPENGL or QT_OPENGL_ES_2 is definedDaniel Schürmann
2020-01-18Fix SkinContext parent/child relationships and overall designUwe Klotz
2020-01-15Fix incorrect emit statements in Mixxx codebaseJan Holthuis
This fixes 1909 instances of -Wclazy-incorrect-emit: $ grep Wclazy-incorrect-emit clazy.log | sort | uniq src/broadcast/broadcastmanager.cpp:111:18: warning: Missing emit keyword on signal call BroadcastManager::broadcastEnabled [-Wclazy-incorrect-emit] src/broadcast/broadcastmanager.cpp:128:10: warning: Missing emit keyword on signal call BroadcastManager::broadcastEnabled [-Wclazy-incorrect-emit] src/broadcast/broadcastmanager.cpp:96:14: warning: Missing emit keyword on signal call BroadcastManager::broadcastEnabled [-Wclazy-incorrect-emit] src/control/control.cpp:182:14: warning: Missing emit keyword on signal call ControlDoublePrivate::valueChangeRequest [-Wclazy-incorrect-emit] src/control/control.cpp:197:10: warning: Missing emit keyword on signal call ControlDoublePrivate::valueChanged [-Wclazy-incorrect-emit] src/control/controlindicator.cpp:24:14: warning: Missing emit keyword on signal call ControlIndicator::blinkValueChanged [-Wclazy-incorrect-emit] src/control/controlmodel.cpp:99:10: warning: Missing emit keyword on signal call QAbstractItemModel::headerDataChanged [-Wclazy-incorrect-emit] src/control/controlobject.cpp:59:14: warning: Missing emit keyword on signal call ControlObject::valueChanged [-Wclazy-incorrect-emit] src/control/controlobjectscript.h:28:14: warning: Missing emit keyword on signal call ControlObjectScript::trigger [-Wclazy-incorrect-emit] src/control/controlproxy.h:164:18: warning: Missing emit keyword on signal call ControlProxy::valueChanged [-Wclazy-incorrect-emit] src/control/controlproxy.h:172:18: warning: Missing emit keyword on signal call ControlProxy::valueChanged [-Wclazy-incorrect-emit] src/control/controlproxy.h:180:18: warning: Missing emit keyword on signal call ControlProxy::valueChanged [-Wclazy-incorrect-emit] src/control/controlproxy.h:95:14: warning: Missing emit keyword on signal call ControlProxy::valueChanged [-Wclazy-incorrect-emit] src/controllers/bulk/bulkcontroller.cpp:115:10: warning: Missing emit keyword on signal call Controller::presetLoaded [-Wclazy-incorrect-emit] src/controllers/bulk/bulkcontroller.cpp:55:18: warning: Missing emit keyword on signal call BulkReader::incomingData [-Wclazy-incorrect-emit] src/controllers/controllerengine.cpp:246:10: warning: Missing emit keyword on signal call ControllerEngine::initialized [-Wclazy-incorrect-emit] src/controllers/controllerengine.cpp:300:10: warning: Missing emit keyword on signal call ControllerEngine::initialized [-Wclazy-incorrect-emit] src/controllers/controllerengine.cpp:533:14: warning: Missing emit keyword on signal call ControllerEngine::resetController [-Wclazy-incorrect-emit] src/controllers/controllerinputmappingtablemodel.cpp:236:22: warning: Missing emit keyword on signal call QAbstractItemModel::dataChanged [-Wclazy-incorrect-emit] src/controllers/controllerinputmappingtablemodel.cpp:242:22: warning: Missing emit keyword on signal call QAbstractItemModel::dataChanged [-Wclazy-incorrect-emit] src/controllers/controllerinputmappingtablemodel.cpp:246:22: warning: Missing emit keyword on signal call QAbstractItemModel::dataChanged [-Wclazy-incorrect-emit] src/controllers/controllerinputmappingtablemodel.cpp:250:22: warning: Missing emit keyword on signal call QAbstractItemModel::dataChanged [-Wclazy-incorrect-emit] src/controllers/controllerinputmappingtablemodel.cpp:254:22: warning: Missing emit keyword on signal call QAbstractItemModel::dataChanged [-Wclazy-incorrect-emit] src/controllers/controllerinputmappingtablemodel.cpp:258:22: warning: Missing emit keyword on signal call QAbstractItemModel::dataChanged [-Wclazy-incorrect-emit] src/controllers/controllerlearningeventfilter.cpp:42:22: warning: Missing emit keyword on signal call ControllerLearningEventFilter::controlClicked [-Wclazy-incorrect-emit] src/controllers/controllerlearningeventfilter.cpp:45:22: warning: Missing emit keyword on signal call ControllerLearningEventFilter::controlClicked [-Wclazy-incorrect-emit] src/controllers/controllerlearningeventfilter.cpp:55:22: warning: Missing emit keyword on signal call ControllerLearningEventFilter::controlClicked [-Wclazy-incorrect-emit] src/controllers/controllerlearningeventfilter.cpp:70:26: warning: Missing emit keyword on signal call ControllerLearningEventFilter::controlClicked [-Wclazy-incorrect-emit] src/controllers/controllerlearningeventfilter.cpp:75:22: warning: Missing emit keyword on signal call ControllerLearningEventFilter::controlClicked [-Wclazy-incorrect-emit] src/controllers/controllermanager.cpp:102:10: warning: Emitting inside constructor probably has no effect [-Wclazy-incorrect-emit] src/controllers/controllermanager.cpp:102:10: warning: Missing emit keyword on signal call ControllerManager::requestInitialize [-Wclazy-incorrect-emit] src/controllers/controllermanager.cpp:106:10: warning: Missing emit keyword on signal call ControllerManager::requestShutdown [-Wclazy-incorrect-emit] src/controllers/controllermanager.cpp:178:14: warning: Missing emit keyword on signal call ControllerManager::devicesChanged [-Wclazy-incorrect-emit] src/controllers/controllermanager.h:40:32: warning: Missing emit keyword on signal call ControllerManager::requestSetUpDevices [-Wclazy-incorrect-emit] src/controllers/controllermanager.h:41:52: warning: Missing emit keyword on signal call ControllerManager::requestSave [-Wclazy-incorrect-emit] src/controllers/controllermappingtablemodel.cpp:56:10: warning: Missing emit keyword on signal call QAbstractItemModel::headerDataChanged [-Wclazy-incorrect-emit] src/controllers/controlleroutputmappingtablemodel.cpp:205:22: warning: Missing emit keyword on signal call QAbstractItemModel::dataChanged [-Wclazy-incorrect-emit] src/controllers/controlleroutputmappingtablemodel.cpp:211:22: warning: Missing emit keyword on signal call QAbstractItemModel::dataChanged [-Wclazy-incorrect-emit] src/controllers/controlleroutputmappingtablemodel.cpp:215:22: warning: Missing emit keyword on signal call QAbstractItemModel::dataChanged [-Wclazy-incorrect-emit] src/controllers/controlleroutputmappingtablemodel.cpp:219:22: warning: Missing emit keyword on signal call QAbstractItemModel::dataChanged [-Wclazy-incorrect-emit] src/controllers/controlleroutputmappingtablemodel.cpp:223:22: warning: Missing emit keyword on signal call QAbstractItemModel::dataChanged [-Wclazy-incorrect-emit] src/controllers/controlleroutputmappingtablemodel.cpp:227:22: warning: Missing emit keyword on signal call QAbstractItemModel::dataChanged [-Wclazy-incorrect-emit] src/controllers/controlleroutputmappingtablemodel.cpp:231:22: warning: Missing emit keyword on signal call QAbstractItemModel::dataChanged [-Wclazy-incorrect-emit] src/controllers/controlleroutputmappingtablemodel.cpp:235:22: warning: Missing emit keyword on signal call QAbstractItemModel::dataChanged [-Wclazy-incorrect-emit] src/controllers/controlleroutputmappingtablemodel.cpp:239:22: warning: Missing emit keyword on signal call QAbstractItemModel::dataChanged [-Wclazy-incorrect-emit] src/controllers/controlpickermenu.cpp:1014:10: warning: Missing emit keyword on signal call ControlPickerMenu::controlPicked [-Wclazy-incorrect-emit] src/controllers/dlgcontrollerlearning.cpp:145:10: warning: Missing emit keyword on signal call DlgControllerLearning::clearTemporaryInputMappings [-Wclazy-incorrect-emit] src/controllers/dlgcontrollerlearning.cpp:186:10: warning: Missing emit keyword on signal call DlgControllerLearning::listenForClicks [-Wclazy-incorrect-emit] src/controllers/dlgcontrollerlearning.cpp:298:10: warning: Missing emit keyword on signal call DlgControllerLearning::learnTemporaryInputMappings [-Wclazy-incorrect-emit] src/controllers/dlgcontrollerlearning.cpp:351:10: warning: Missing emit keyword on signal call DlgControllerLearning::clearTemporaryInputMappings [-Wclazy-incorrect-emit] src/controllers/dlgcontrollerlearning.cpp:364:10: warning: Missing emit keyword on signal call DlgControllerLearning::learnTemporaryInputMappings [-Wclazy-incorrect-emit] src/controllers/dlgcontrollerlearning.cpp:368:10: warning: Missing emit keyword on signal call DlgControllerLearning::commitTemporaryInputMappings [-Wclazy-incorrect-emit] src/controllers/dlgcontrollerlearning.cpp:369:10: warning: Missing emit keyword on signal call DlgControllerLearning::inputMappingsLearned [-Wclazy-incorrect-emit] src/controllers/dlgcontrollerlearning.cpp:395:10: warning: Missing emit keyword on signal call DlgControllerLearning::startLearning [-Wclazy-incorrect-emit] src/controllers/dlgcontrollerlearning.cpp:417:10: warning: Missing emit keyword on signal call DlgControllerLearning::stopLearning [-Wclazy-incorrect-emit] src/controllers/dlgcontrollerlearning.cpp:418:10: warning: Missing emit keyword on signal call DlgControllerLearning::stopListeningForClicks [-Wclazy-incorrect-emit] src/controllers/dlgprefcontroller.cpp:150:10: warning: Missing emit keyword on signal call DlgPrefController::mappingStarted [-Wclazy-incorrect-emit] src/controllers/dlgprefcontroller.cpp:334:14: warning: Missing emit keyword on signal call DlgPrefController::loadPreset [-Wclazy-incorrect-emit] src/controllers/dlgprefcontroller.cpp:397:10: warning: Missing emit keyword on signal call DlgPrefController::loadPreset [-Wclazy-incorrect-emit] src/controllers/dlgprefcontroller.cpp:548:10: warning: Missing emit keyword on signal call DlgPrefController::controllerEnabled [-Wclazy-incorrect-emit] src/controllers/dlgprefcontroller.cpp:552:10: warning: Missing emit keyword on signal call DlgPrefController::openController [-Wclazy-incorrect-emit] src/controllers/dlgprefcontroller.cpp:557:10: warning: Missing emit keyword on signal call DlgPrefController::closeController [-Wclazy-incorrect-emit] src/controllers/hid/hidcontroller.cpp:99:10: warning: Missing emit keyword on signal call Controller::presetLoaded [-Wclazy-incorrect-emit] src/controllers/midi/midicontroller.cpp:210:14: warning: Missing emit keyword on signal call MidiController::messageReceived [-Wclazy-incorrect-emit] src/controllers/midi/midicontroller.cpp:36:10: warning: Missing emit keyword on signal call Controller::presetLoaded [-Wclazy-incorrect-emit] src/controllers/midi/midicontroller.cpp:461:14: warning: Missing emit keyword on signal call MidiController::messageReceived [-Wclazy-incorrect-emit] src/effects/effectbuttonparameterslot.cpp:99:10: warning: Missing emit keyword on signal call EffectParameterSlotBase::updated [-Wclazy-incorrect-emit] src/effects/effectbuttonparameterslot.cpp:84:10: warning: Missing emit keyword on signal call EffectParameterSlotBase::updated [-Wclazy-incorrect-emit] src/effects/effectchain.cpp:135:10: warning: Missing emit keyword on signal call EffectChain::nameChanged [-Wclazy-incorrect-emit] src/effects/effectchain.cpp:144:10: warning: Missing emit keyword on signal call EffectChain::descriptionChanged [-Wclazy-incorrect-emit] src/effects/effectchain.cpp:154:10: warning: Missing emit keyword on signal call EffectChain::enabledChanged [-Wclazy-incorrect-emit] src/effects/effectchain.cpp:210:10: warning: Missing emit keyword on signal call EffectChain::channelStatusChanged [-Wclazy-incorrect-emit] src/effects/effectchain.cpp:228:14: warning: Missing emit keyword on signal call EffectChain::channelStatusChanged [-Wclazy-incorrect-emit] src/effects/effectchain.cpp:239:10: warning: Missing emit keyword on signal call EffectChain::mixChanged [-Wclazy-incorrect-emit] src/effects/effectchain.cpp:249:10: warning: Missing emit keyword on signal call EffectChain::mixModeChanged [-Wclazy-incorrect-emit] src/effects/effectchain.cpp:269:10: warning: Missing emit keyword on signal call EffectChain::effectChanged [-Wclazy-incorrect-emit] src/effects/effectchain.cpp:296:10: warning: Missing emit keyword on signal call EffectChain::effectChanged [-Wclazy-incorrect-emit] src/effects/effectchain.cpp:305:14: warning: Missing emit keyword on signal call EffectChain::effectChanged [-Wclazy-incorrect-emit] src/effects/effectchainslot.cpp:135:10: warning: Missing emit keyword on signal call EffectChainSlot::updated [-Wclazy-incorrect-emit] src/effects/effectchainslot.cpp:140:10: warning: Missing emit keyword on signal call EffectChainSlot::updated [-Wclazy-incorrect-emit] src/effects/effectchainslot.cpp:145:10: warning: Missing emit keyword on signal call EffectChainSlot::updated [-Wclazy-incorrect-emit] src/effects/effectchainslot.cpp:150:10: warning: Missing emit keyword on signal call EffectChainSlot::updated [-Wclazy-incorrect-emit] src/effects/effectchainslot.cpp:158:14: warning: Missing emit keyword on signal call EffectChainSlot::updated [-Wclazy-incorrect-emit] src/effects/effectchainslot.cpp:189:18: warning: Missing emit keyword on signal call EffectChainSlot::updated [-Wclazy-incorrect-emit] src/effects/effectchainslot.cpp:229:10: warning: Missing emit keyword on signal call EffectChainSlot::effectChainLoaded [-Wclazy-incorrect-emit] src/effects/effectchainslot.cpp:230:10: warning: Missing emit keyword on signal call EffectChainSlot::updated [-Wclazy-incorrect-emit] src/effects/effectchainslot.cpp:280:10: warning: Missing emit keyword on signal call EffectChainSlot::updated [-Wclazy-incorrect-emit] src/effects/effectchainslot.cpp:336:10: warning: Missing emit keyword on signal call EffectChainSlot::effectLoaded [-Wclazy-incorrect-emit] src/effects/effectchainslot.cpp:407:14: warning: Missing emit keyword on signal call EffectChainSlot::nextChain [-Wclazy-incorrect-emit] src/effects/effectchainslot.cpp:409:14: warning: Missing emit keyword on signal call EffectChainSlot::prevChain [-Wclazy-incorrect-emit] src/effects/effect.cpp:117:14: warning: Missing emit keyword on signal call Effect::enabledChanged [-Wclazy-incorrect-emit] src/effects/effectparameter.cpp:116:10: warning: Missing emit keyword on signal call EffectParameter::valueChanged [-Wclazy-incorrect-emit] src/effects/effectparameterslot.cpp:99:10: warning: Missing emit keyword on signal call EffectParameterSlotBase::updated [-Wclazy-incorrect-emit] src/effects/effectparameterslot.cpp:117:10: warning: Missing emit keyword on signal call EffectParameterSlotBase::updated [-Wclazy-incorrect-emit] src/effects/effectsbackend.cpp:28:10: warning: Missing emit keyword on signal call EffectsBackend::effectRegistered [-Wclazy-incorrect-emit] src/effects/effectslot.cpp:194:14: warning: Missing emit keyword on signal call EffectSlot::effectLoaded [-Wclazy-incorrect-emit] src/effects/effectslot.cpp:198:14: warning: Missing emit keyword on signal call EffectSlot::effectLoaded [-Wclazy-incorrect-emit] src/effects/effectslot.cpp:200:10: warning: Missing emit keyword on signal call EffectSlot::updated [-Wclazy-incorrect-emit] src/effects/effectslot.cpp:217:10: warning: Missing emit keyword on signal call EffectSlot::updated [-Wclazy-incorrect-emit] src/effects/effectslot.cpp:234:14: warning: Missing emit keyword on signal call EffectSlot::nextEffect [-Wclazy-incorrect-emit] src/effects/effectslot.cpp:236:14: warning: Missing emit keyword on signal call EffectSlot::prevEffect [-Wclazy-incorrect-emit] src/effects/effectslot.cpp:242:14: warning: Missing emit keyword on signal call EffectSlot::clearEffect [-Wclazy-incorrect-emit] src/effects/effectsmanager.cpp:323:14: warning: Missing emit keyword on signal call EffectsManager::visibleEffectsUpdated [-Wclazy-incorrect-emit] src/effects/effectsmanager.cpp:326:14: warning: Missing emit keyword on signal call EffectsManager::visibleEffectsUpdated [-Wclazy-incorrect-emit] src/engine/controls/cuecontrol.cpp:1815:10: warning: Missing emit keyword on signal call HotcueControl::hotcueSet [-Wclazy-incorrect-emit] src/engine/controls/cuecontrol.cpp:1819:10: warning: Missing emit keyword on signal call HotcueControl::hotcueGoto [-Wclazy-incorrect-emit] src/engine/controls/cuecontrol.cpp:1823:10: warning: Missing emit keyword on signal call HotcueControl::hotcueGotoAndPlay [-Wclazy-incorrect-emit] src/engine/controls/cuecontrol.cpp:1827:10: warning: Missing emit keyword on signal call HotcueControl::hotcueGotoAndStop [-Wclazy-incorrect-emit] src/engine/controls/cuecontrol.cpp:1831:10: warning: Missing emit keyword on signal call HotcueControl::hotcueActivate [-Wclazy-incorrect-emit] src/engine/controls/cuecontrol.cpp:1835:10: warning: Missing emit keyword on signal call HotcueControl::hotcueActivatePreview [-Wclazy-incorrect-emit] src/engine/controls/cuecontrol.cpp:1839:10: warning: Missing emit keyword on signal call HotcueControl::hotcueClear [-Wclazy-incorrect-emit] src/engine/controls/cuecontrol.cpp:1844:10: warning: Missing emit keyword on signal call HotcueControl::hotcuePositionChanged [-Wclazy-incorrect-emit] src/engine/controls/cuecontrol.cpp:1849:10: warning: Missing emit keyword on signal call HotcueControl::hotcueColorChanged [-Wclazy-incorrect-emit] src/engine/controls/loopingcontrol.cpp:1334:14: warning: Missing emit keyword on signal call BeatJumpControl::beatJump [-Wclazy-incorrect-emit] src/engine/controls/loopingcontrol.cpp:1340:14: warning: Missing emit keyword on signal call BeatJumpControl::beatJump [-Wclazy-incorrect-emit] src/engine/controls/loopingcontrol.cpp:1365:14: warning: Missing emit keyword on signal call LoopMoveControl::loopMove [-Wclazy-incorrect-emit] src/engine/controls/loopingcontrol.cpp:1371:14: warning: Missing emit keyword on signal call LoopMoveControl::loopMove [-Wclazy-incorrect-emit] src/engine/controls/loopingcontrol.cpp:1439:14: warning: Missing emit keyword on signal call BeatLoopingControl::activateBeatLoop [-Wclazy-incorrect-emit] src/engine/controls/loopingcontrol.cpp:1441:14: warning: Missing emit keyword on signal call BeatLoopingControl::deactivateBeatLoop [-Wclazy-incorrect-emit] src/engine/controls/loopingcontrol.cpp:1450:10: warning: Missing emit keyword on signal call BeatLoopingControl::activateBeatLoop [-Wclazy-incorrect-emit] src/engine/controls/loopingcontrol.cpp:1456:14: warning: Missing emit keyword on signal call BeatLoopingControl::activateBeatLoopRoll [-Wclazy-incorrect-emit] src/engine/controls/loopingcontrol.cpp:1458:14: warning: Missing emit keyword on signal call BeatLoopingControl::deactivateBeatLoopRoll [-Wclazy-incorrect-emit] src/engine/controls/loopingcontrol.cpp:1468:14: warning: Missing emit keyword on signal call BeatLoopingControl::deactivateBeatLoop [-Wclazy-incorrect-emit] src/engine/controls/loopingcontrol.cpp:1470:14: warning: Missing emit keyword on signal call BeatLoopingControl::activateBeatLoop [-Wclazy-incorrect-emit] src/engine/enginebuffer.cpp:1370:10: warning: Missing emit keyword on signal call EngineBuffer::trackLoaded [-Wclazy-incorrect-emit] src/engine/enginebuffer.cpp:534:10: warning: Missing emit keyword on signal call EngineBuffer::trackLoadFailed [-Wclazy-incorrect-emit] src/engine/sidechain/enginerecord.cpp:121:18: warning: Missing emit keyword on signal call EngineRecord::isRecording [-Wclazy-incorrect-emit] src/engine/sidechain/enginerecord.cpp:131:18: warning: Missing emit keyword on signal call EngineRecord::isRecording [-Wclazy-incorrect-emit] src/engine/sidechain/enginerecord.cpp:150:18: warning: Missing emit keyword on signal call EngineRecord::isRecording [-Wclazy-incorrect-emit] src/engine/sidechain/enginerecord.cpp:163:18: warning: Missing emit keyword on signal call EngineRecord::isRecording [-Wclazy-incorrect-emit] src/engine/sidechain/enginerecord.cpp:184:18: warning: Missing emit keyword on signal call EngineRecord::isRecording [-Wclazy-incorrect-emit] src/engine/sidechain/enginerecord.cpp:211:18: warning: Missing emit keyword on signal call EngineRecord::durationRecorded [-Wclazy-incorrect-emit] src/engine/sidechain/enginerecord.cpp:261:10: warning: Missing emit keyword on signal call EngineRecord::bytesRecorded [-Wclazy-incorrect-emit] src/engine/sidechain/shoutconnection.cpp:595:18: warning: Missing emit keyword on signal call ShoutConnection::broadcastConnected [-Wclazy-incorrect-emit] src/engine/sidechain/shoutconnection.cpp:636:14: warning: Missing emit keyword on signal call ShoutConnection::broadcastDisconnected [-Wclazy-incorrect-emit] src/errordialoghandler.cpp:138:10: warning: Missing emit keyword on signal call ErrorDialogHandler::showErrorDialog [-Wclazy-incorrect-emit] src/errordialoghandler.cpp:214:10: warning: Missing emit keyword on signal call ErrorDialogHandler::stdButtonClicked [-Wclazy-incorrect-emit] src/library/analysisfeature.cpp:112:10: warning: Missing emit keyword on signal call AnalysisFeature::analysisActive [-Wclazy-incorrect-emit] src/library/autodj/autodjfeature.cpp:163:10: warning: Missing emit keyword on signal call LibraryFeature::switchToView [-Wclazy-incorrect-emit] src/library/autodj/autodjfeature.cpp:165:10: warning: Missing emit keyword on signal call LibraryFeature::enableCoverArtDisplay [-Wclazy-incorrect-emit] src/library/autodj/autodjprocessor.cpp:101:10: warning: Missing emit keyword on signal call DeckAttributes::rateChanged [-Wclazy-incorrect-emit] src/library/autodj/autodjprocessor.cpp:63:10: warning: Missing emit keyword on signal call DeckAttributes::playChanged [-Wclazy-incorrect-emit] src/library/autodj/autodjprocessor.cpp:67:10: warning: Missing emit keyword on signal call DeckAttributes::playPositionChanged [-Wclazy-incorrect-emit] src/library/autodj/autodjprocessor.cpp:71:10: warning: Missing emit keyword on signal call DeckAttributes::introStartPositionChanged [-Wclazy-incorrect-emit] src/library/autodj/autodjprocessor.cpp:75:10: warning: Missing emit keyword on signal call DeckAttributes::introEndPositionChanged [-Wclazy-incorrect-emit] src/library/autodj/autodjprocessor.cpp:79:10: warning: Missing emit keyword on signal call DeckAttributes::outroStartPositionChanged [-Wclazy-incorrect-emit] src/library/autodj/autodjprocessor.cpp:815:14: warning: Missing emit keyword on signal call AutoDJProcessor::randomTrackRequested [-Wclazy-incorrect-emit] src/library/autodj/autodjprocessor.cpp:83:10: warning: Missing emit keyword on signal call DeckAttributes::outroEndPositionChanged [-Wclazy-incorrect-emit] src/library/autodj/autodjprocessor.cpp:87:10: warning: Missing emit keyword on signal call DeckAttributes::trackLoaded [-Wclazy-incorrect-emit] src/library/autodj/autodjprocessor.cpp:902:14: warning: Missing emit keyword on signal call AutoDJProcessor::randomTrackRequested [-Wclazy-incorrect-emit] src/library/autodj/autodjprocessor.cpp:92:10: warning: Missing emit keyword on signal call DeckAttributes::loadingTrack [-Wclazy-incorrect-emit] src/library/autodj/autodjprocessor.cpp:96:10: warning: Missing emit keyword on signal call DeckAttributes::playerEmpty [-Wclazy-incorrect-emit] src/library/autodj/autodjprocessor.h:237:14: warning: Missing emit keyword on signal call AutoDJProcessor::loadTrackToPlayer [-Wclazy-incorrect-emit] src/library/autodj/autodjprocessor.h:240:14: warning: Missing emit keyword on signal call AutoDJProcessor::autoDJStateChanged [-Wclazy-incorrect-emit] src/library/banshee/bansheefeature.cpp:109:14: warning: Missing emit keyword on signal call LibraryFeature::featureLoadingFinished [-Wclazy-incorrect-emit] src/library/banshee/bansheefeature.cpp:113:10: warning: Missing emit keyword on signal call LibraryFeature::showTrackModel [-Wclazy-incorrect-emit] src/library/banshee/bansheefeature.cpp:114:10: warning: Missing emit keyword on signal call LibraryFeature::enableCoverArtDisplay [-Wclazy-incorrect-emit] src/library/banshee/bansheefeature.cpp:123:14: warning: Missing emit keyword on signal call LibraryFeature::showTrackModel [-Wclazy-incorrect-emit] src/library/banshee/bansheefeature.cpp:124:14: warning: Missing emit keyword on signal call LibraryFeature::enableCoverArtDisplay [-Wclazy-incorrect-emit] src/library/banshee/bansheeplaylistmodel.cpp:285:22: warning: Missing emit keyword on signal call QAbstractItemModel::dataChanged [-Wclazy-incorrect-emit] src/library/baseexternalplaylistmodel.cpp:158:22: warning: Missing emit keyword on signal call QAbstractItemModel::dataChanged [-Wclazy-incorrect-emit] src/library/baseexternaltrackmodel.cpp:101:22: warning: Missing emit keyword on signal call QAbstractItemModel::dataChanged [-Wclazy-incorrect-emit] src/library/baseplaylistfeature.cpp:165:10: warning: Missing emit keyword on signal call LibraryFeature::switchToView [-Wclazy-incorrect-emit] src/library/baseplaylistfeature.cpp:167:10: warning: Missing emit keyword on signal call LibraryFeature::enableCoverArtDisplay [-Wclazy-incorrect-emit] src/library/baseplaylistfeature.cpp:178:14: warning: Missing emit keyword on signal call LibraryFeature::showTrackModel [-Wclazy-incorrect-emit] src/library/baseplaylistfeature.cpp:179:14: warning: Missing emit keyword on signal call LibraryFeature::enableCoverArtDisplay [-Wclazy-incorrect-emit] src/library/baseplaylistfeature.cpp:191:14: warning: Missing emit keyword on signal call LibraryFeature::showTrackModel [-Wclazy-incorrect-emit] src/library/baseplaylistfeature.cpp:192:14: warning: Missing emit keyword on signal call LibraryFeature::enableCoverArtDisplay [-Wclazy-incorrect-emit] src/library/baseplaylistfeature.cpp:194:14: warning: Missing emit keyword on signal call LibraryFeature::featureSelect [-Wclazy-incorrect-emit] src/library/baseplaylistfeature.cpp:629:18: warning: Missing emit keyword on signal call BasePlaylistFeature::analyzeTracks [-Wclazy-incorrect-emit] src/library/basesqltablemodel.cpp:1145:10: warning: Missing emit keyword on signal call QAbstractItemModel::dataChanged [-Wclazy-incorrect-emit] src/library/basesqltablemodel.cpp:185:10: warning: Missing emit keyword on signal call QAbstractItemModel::headerDataChanged [-Wclazy-incorrect-emit] src/library/basesqltablemodel.cpp:953:22: warning: Missing emit keyword on signal call QAbstractItemModel::dataChanged [-Wclazy-incorrect-emit] src/library/basesqltablemodel.cpp:972:18: warning: Missing emit keyword on signal call QAbstractItemModel::dataChanged [-Wclazy-incorrect-emit] src/library/basetrackcache.cpp:171:10: warning: Missing emit keyword on signal call BaseTrackCache::tracksChanged [-Wclazy-incorrect-emit] src/library/basetrackcache.cpp:409:10: warning: Missing emit keyword on signal call BaseTrackCache::tracksChanged [-Wclazy-incorrect-emit] src/library/browse/browsefeature.cpp:170:10: warning: Missing emit keyword on signal call BrowseFeature::requestAddDir [-Wclazy-incorrect-emit] src/library/browse/browsefeature.cpp:186:14: warning: Missing emit keyword on signal call BrowseFeature::scanLibrary [-Wclazy-incorrect-emit] src/library/browse/browsefeature.cpp:239:10: warning: Missing emit keyword on signal call LibraryFeature::switchToView [-Wclazy-incorrect-emit] src/library/browse/browsefeature.cpp:241:10: warning: Missing emit keyword on signal call LibraryFeature::enableCoverArtDisplay [-Wclazy-incorrect-emit] src/library/browse/browsefeature.cpp:269:10: warning: Missing emit keyword on signal call LibraryFeature::showTrackModel [-Wclazy-incorrect-emit] src/library/browse/browsefeature.cpp:270:10: warning: Missing emit keyword on signal call LibraryFeature::enableCoverArtDisplay [-Wclazy-incorrect-emit] src/library/browse/browsethread.cpp:129:10: warning: Missing emit keyword on signal call BrowseThread::clearModel [-Wclazy-incorrect-emit] src/library/browse/browsethread.cpp:276:18: warning: Missing emit keyword on signal call BrowseThread::rowsAppended [-Wclazy-incorrect-emit] src/library/browse/browsethread.cpp:283:10: warning: Missing emit keyword on signal call BrowseThread::rowsAppended [-Wclazy-incorrect-emit] src/library/coverartcache.cpp:191:14: warning: Missing emit keyword on signal call CoverArtCache::coverFound [-Wclazy-incorrect-emit] src/library/coverartcache.cpp:60:18: warning: Missing emit keyword on signal call CoverArtCache::coverFound [-Wclazy-incorrect-emit] src/library/coverartcache.cpp:86:18: warning: Missing emit keyword on signal call CoverArtCache::coverFound [-Wclazy-incorrect-emit] src/library/coverartdelegate.cpp:67:18: warning: Missing emit keyword on signal call CoverArtDelegate::coverReadyForCell [-Wclazy-incorrect-emit] src/library/coverartdelegate.cpp:81:18: warning: Missing emit keyword on signal call CoverArtDelegate::coverReadyForCell [-Wclazy-incorrect-emit] src/library/crate/cratefeature.cpp:290:10: warning: Missing emit keyword on signal call LibraryFeature::switchToView [-Wclazy-incorrect-emit] src/library/crate/cratefeature.cpp:292:10: warning: Missing emit keyword on signal call LibraryFeature::enableCoverArtDisplay [-Wclazy-incorrect-emit] src/library/crate/cratefeature.cpp:301:10: warning: Missing emit keyword on signal call LibraryFeature::showTrackModel [-Wclazy-incorrect-emit] src/library/crate/cratefeature.cpp:302:10: warning: Missing emit keyword on signal call LibraryFeature::enableCoverArtDisplay [-Wclazy-incorrect-emit] src/library/crate/cratefeature.cpp:316:10: warning: Missing emit keyword on signal call LibraryFeature::showTrackModel [-Wclazy-incorrect-emit] src/library/crate/cratefeature.cpp:317:10: warning: Missing emit keyword on signal call LibraryFeature::enableCoverArtDisplay [-Wclazy-incorrect-emit] src/library/crate/cratefeature.cpp:319:10: warning: Missing emit keyword on signal call LibraryFeature::featureSelect [-Wclazy-incorrect-emit] src/library/crate/cratefeature.cpp:680:18: warning: Missing emit keyword on signal call CrateFeature::analyzeTracks [-Wclazy-incorrect-emit] src/library/dao/playlistdao.cpp:199:10: warning: Missing emit keyword on signal call PlaylistDAO::deleted [-Wclazy-incorrect-emit] src/library/dao/playlistdao.cpp:211:10: warning: Missing emit keyword on signal call PlaylistDAO::renamed [-Wclazy-incorrect-emit] src/library/dao/playlistdao.cpp:226:10: warning: Missing emit keyword on signal call PlaylistDAO::lockChanged [-Wclazy-incorrect-emit] src/library/dao/playlistdao.cpp:299:14: warning: Missing emit keyword on signal call PlaylistDAO::trackAdded [-Wclazy-incorrect-emit] src/library/dao/playlistdao.cpp:508:10: warning: Missing emit keyword on signal call PlaylistDAO::trackRemoved [-Wclazy-incorrect-emit] src/library/dao/playlistdao.cpp:552:10: warning: Missing emit keyword on signal call PlaylistDAO::trackAdded [-Wclazy-incorrect-emit] src/library/dao/playlistdao.cpp:612:14: warning: Missing emit keyword on signal call PlaylistDAO::trackAdded [-Wclazy-incorrect-emit] src/library/dao/playlistdao.cpp:713:14: warning: Missing emit keyword on signal call PlaylistDAO::trackAdded [-Wclazy-incorrect-emit] src/library/dao/playlistdao.cpp:85:10: warning: Missing emit keyword on signal call PlaylistDAO::added [-Wclazy-incorrect-emit] src/library/dao/trackdao.cpp:1396:14: warning: Missing emit keyword on signal call TrackDAO::trackDirty [-Wclazy-incorrect-emit] src/library/dao/trackdao.cpp:1398:14: warning: Missing emit keyword on signal call TrackDAO::trackClean [-Wclazy-incorrect-emit] src/library/dao/trackdao.cpp:1587:10: warning: Missing emit keyword on signal call TrackDAO::tracksRemoved [-Wclazy-incorrect-emit] src/library/dao/trackdao.cpp:1863:14: warning: Missing emit keyword on signal call TrackDAO::progressVerifyTracksOutside [-Wclazy-incorrect-emit] src/library/dao/trackdao.cpp:1951:14: warning: Missing emit keyword on signal call TrackDAO::progressCoverArt [-Wclazy-incorrect-emit] src/library/dao/trackdao.cpp:314:22: warning: Missing emit keyword on signal call TrackDAO::trackClean [-Wclazy-incorrect-emit] src/library/dao/trackdao.cpp:336:14: warning: Missing emit keyword on signal call TrackDAO::trackDirty [-Wclazy-incorrect-emit] src/library/dao/trackdao.cpp:356:14: warning: Missing emit keyword on signal call TrackDAO::trackClean [-Wclazy-incorrect-emit] src/library/dao/trackdao.cpp:418:14: warning: Missing emit keyword on signal call TrackDAO::trackChanged [-Wclazy-incorrect-emit] src/library/dao/trackdao.cpp:492:10: warning: Missing emit keyword on signal call TrackDAO::tracksAdded [-Wclazy-incorrect-emit] src/library/dao/trackdao.cpp:823:10: warning: Missing emit keyword on signal call TrackDAO::tracksRemoved [-Wclazy-incorrect-emit] src/library/dao/trackdao.cpp:856:10: warning: Missing emit keyword on signal call TrackDAO::tracksAdded [-Wclazy-incorrect-emit] src/library/dao/trackdao.cpp:975:10: warning: Missing emit keyword on signal call TrackDAO::tracksRemoved [-Wclazy-incorrect-emit] src/library/dao/trackdao.cpp:977:10: warning: Missing emit keyword on signal call TrackDAO::forceModelUpdate [-Wclazy-incorrect-emit] src/library/dlganalysis.cpp:146:14: warning: Missing emit keyword on signal call DlgAnalysis::stopAnalysis [-Wclazy-incorrect-emit] src/library/dlganalysis.cpp:159:14: warning: Missing emit keyword on signal call DlgAnalysis::analyzeTracks [-Wclazy-incorrect-emit] src/library/dlgtrackinfo.cpp:157:10: warning: Missing emit keyword on signal call DlgTrackInfo::next [-Wclazy-incorrect-emit] src/library/dlgtrackinfo.cpp:161:10: warning: Missing emit keyword on signal call DlgTrackInfo::previous [-Wclazy-incorrect-emit] src/library/dlgtrackinfo.cpp:751:10: warning: Missing emit keyword on signal call DlgTrackInfo::showTagFetcher [-Wclazy-incorrect-emit] src/library/export/trackexportworker.cpp:155:10: warning: Missing emit keyword on signal call TrackExportWorker::askOverwriteMode [-Wclazy-incorrect-emit] src/library/export/trackexportworker.cpp:79:14: warning: Missing emit keyword on signal call TrackExportWorker::progress [-Wclazy-incorrect-emit] src/library/export/trackexportworker.cpp:82:18: warning: Missing emit keyword on signal call TrackExportWorker::canceled [-Wclazy-incorrect-emit] src/library/export/trackexportworker.cpp:86:14: warning: Missing emit keyword on signal call TrackExportWorker::progress [-Wclazy-incorrect-emit] src/library/itunes/itunesfeature.cpp:159:10: warning: Missing emit keyword on signal call LibraryFeature::enableCoverArtDisplay [-Wclazy-incorrect-emit] src/library/itunes/itunesfeature.cpp:173:14: warning: Missing emit keyword on signal call LibraryFeature::showTrackModel [-Wclazy-incorrect-emit] src/library/itunes/itunesfeature.cpp:215:14: warning: Missing emit keyword on signal call LibraryFeature::featureIsLoading [-Wclazy-incorrect-emit] src/library/itunes/itunesfeature.cpp:217:14: warning: Missing emit keyword on signal call LibraryFeature::showTrackModel [-Wclazy-incorrect-emit] src/library/itunes/itunesfeature.cpp:219:10: warning: Missing emit keyword on signal call LibraryFeature::enableCoverArtDisplay [-Wclazy-incorrect-emit] src/library/itunes/itunesfeature.cpp:227:10: warning: Missing emit keyword on signal call LibraryFeature::showTrackModel [-Wclazy-incorrect-emit] src/library/itunes/itunesfeature.cpp:228:10: warning: Missing emit keyword on signal call LibraryFeature::enableCoverArtDisplay [-Wclazy-incorrect-emit] src/library/itunes/itunesfeature.cpp:818:14: warning: Missing emit keyword on signal call LibraryFeature::showTrackModel [-Wclazy-incorrect-emit] src/library/itunes/itunesfeature.cpp:829:10: warning: Missing emit keyword on signal call LibraryFeature::featureLoadingFinished [-Wclazy-incorrect-emit] src/library/librarycontrol.cpp:42:14: warning: Missing emit keyword on signal call LoadToGroupController::loadToGroup [-Wclazy-incorrect-emit] src/library/librarycontrol.cpp:48:14: warning: Missing emit keyword on signal call LoadToGroupController::loadToGroup [-Wclazy-incorrect-emit] src/library/library.cpp:319:10: warning: Missing emit keyword on signal call Library::setTrackTableFont [-Wclazy-incorrect-emit] src/library/library.cpp:320:10: warning: Missing emit keyword on signal call Library::setTrackTableRowHeight [-Wclazy-incorrect-emit] src/library/library.cpp:321:10: warning: Missing emit keyword on signal call Library::setSelectedClick [-Wclazy-incorrect-emit] src/library/library.cpp:383:10: warning: Missing emit keyword on signal call Library::showTrackModel [-Wclazy-incorrect-emit] src/library/library.cpp:384:10: warning: Missing emit keyword on signal call Library::switchToView [-Wclazy-incorrect-emit] src/library/library.cpp:385:10: warning: Missing emit keyword on signal call Library::restoreSearch [-Wclazy-incorrect-emit] src/library/library.cpp:390:10: warning: Missing emit keyword on signal call Library::switchToView [-Wclazy-incorrect-emit] src/library/library.cpp:394:10: warning: Missing emit keyword on signal call Library::loadTrack [-Wclazy-incorrect-emit] src/library/library.cpp:401:14: warning: Missing emit keyword on signal call Library::loadTrackToPlayer [-Wclazy-incorrect-emit] src/library/library.cpp:406:10: warning: Missing emit keyword on signal call Library::loadTrackToPlayer [-Wclazy-incorrect-emit] src/library/library.cpp:511:10: warning: Missing emit keyword on signal call Library::setTrackTableFont [-Wclazy-incorrect-emit] src/library/library.cpp:516:10: warning: Missing emit keyword on signal call Library::setTrackTableRowHeight [-Wclazy-incorrect-emit] src/library/library.cpp:521:10: warning: Missing emit keyword on signal call Library::setSelectedClick [-Wclazy-incorrect-emit] src/library/mixxxlibraryfeature.cpp:149:10: warning: Missing emit keyword on signal call LibraryFeature::showTrackModel [-Wclazy-incorrect-emit] src/library/mixxxlibraryfeature.cpp:150:10: warning: Missing emit keyword on signal call LibraryFeature::enableCoverArtDisplay [-Wclazy-incorrect-emit] src/library/mixxxlibraryfeature.cpp:155:10: warning: Missing emit keyword on signal call LibraryFeature::switchToView [-Wclazy-incorrect-emit] src/library/mixxxlibraryfeature.cpp:157:14: warning: Missing emit keyword on signal call LibraryFeature::restoreSearch [-Wclazy-incorrect-emit] src/library/mixxxlibraryfeature.cpp:159:14: warning: Missing emit keyword on signal call LibraryFeature::restoreSearch [-Wclazy-incorrect-emit] src/library/mixxxlibraryfeature.cpp:161:10: warning: Missing emit keyword on signal call LibraryFeature::enableCoverArtDisplay [-Wclazy-incorrect-emit] src/library/previewbuttondelegate.cpp:169:14: warning: Missing emit keyword on signal call PreviewButtonDelegate::loadTrackToPlayer [-Wclazy-incorrect-emit] src/library/previewbuttondelegate.cpp:191:18: warning: Missing emit keyword on signal call PreviewButtonDelegate::buttonSetChecked [-Wclazy-incorrect-emit] src/library/recording/dlgrecording.cpp:104:10: warning: Missing emit keyword on signal call DlgRecording::restoreSearch [-Wclazy-incorrect-emit] src/library/recording/recordingfeature.cpp:72:10: warning: Missing emit keyword on signal call RecordingFeature::refreshBrowseModel [-Wclazy-incorrect-emit] src/library/recording/recordingfeature.cpp:73:10: warning: Missing emit keyword on signal call LibraryFeature::switchToView [-Wclazy-incorrect-emit] src/library/recording/recordingfeature.cpp:75:10: warning: Missing emit keyword on signal call RecordingFeature::requestRestoreSearch [-Wclazy-incorrect-emit] src/library/recording/recordingfeature.cpp:76:10: warning: Missing emit keyword on signal call LibraryFeature::enableCoverArtDisplay [-Wclazy-incorrect-emit] src/library/rekordbox/rekordboxfeature.cpp:1154:10: warning: Missing emit keyword on signal call LibraryFeature::featureIsLoading [-Wclazy-incorrect-emit] src/library/rekordbox/rekordboxfeature.cpp:1156:10: warning: Missing emit keyword on signal call LibraryFeature::enableCoverArtDisplay [-Wclazy-incorrect-emit] src/library/rekordbox/rekordboxfeature.cpp:1157:10: warning: Missing emit keyword on signal call LibraryFeature::switchToView [-Wclazy-incorrect-emit] src/library/rekordbox/rekordboxfeature.cpp:1197:14: warning: Missing emit keyword on signal call LibraryFeature::showTrackModel [-Wclazy-incorrect-emit] src/library/rekordbox/rekordboxfeature.cpp:1268:10: warning: Missing emit keyword on signal call LibraryFeature::featureLoadingFinished [-Wclazy-incorrect-emit] src/library/rekordbox/rekordboxfeature.cpp:1280:10: warning: Missing emit keyword on signal call LibraryFeature::showTrackModel [-Wclazy-incorrect-emit] src/library/rhythmbox/rhythmboxfeature.cpp:123:14: warning: Missing emit keyword on signal call LibraryFeature::featureIsLoading [-Wclazy-incorrect-emit] src/library/rhythmbox/rhythmboxfeature.cpp:126:10: warning: Missing emit keyword on signal call LibraryFeature::showTrackModel [-Wclazy-incorrect-emit] src/library/rhythmbox/rhythmboxfeature.cpp:127:10: warning: Missing emit keyword on signal call LibraryFeature::enableCoverArtDisplay [-Wclazy-incorrect-emit] src/library/rhythmbox/rhythmboxfeature.cpp:135:10: warning: Missing emit keyword on signal call LibraryFeature::showTrackModel [-Wclazy-incorrect-emit] src/library/rhythmbox/rhythmboxfeature.cpp:136:10: warning: Missing emit keyword on signal call LibraryFeature::enableCoverArtDisplay [-Wclazy-incorrect-emit] src/library/rhythmbox/rhythmboxfeature.cpp:441:10: warning: Missing emit keyword on signal call LibraryFeature::featureLoadingFinished [-W