preference pages: create hyperlink color only on demand

9 files changed, 17 insertions, 2 deletions

diff --git a/src/controllers/dlgprefcontroller.cpp b/src/controllers/dlgprefcontroller.cpp
index 8158e45992..4e51eb4db3 100644
--- a/src/controllers/dlgprefcontroller.cpp
+++ b/src/controllers/dlgprefcontroller.cpp
@@ -38,6 +38,8 @@ DlgPrefController::DlgPrefController(QWidget* parent,
           m_pOutputProxyModel(nullptr),
           m_bDirty(false) {
     m_ui.setupUi(this);
+    // Create text color for the file and wiki links
+    createLinkColor();
 
     initTableView(m_ui.m_pInputMappingTableView);
     initTableView(m_ui.m_pOutputMappingTableView);
diff --git a/src/controllers/dlgprefcontrollers.cpp b/src/controllers/dlgprefcontrollers.cpp
index d66daa7ea7..9adef3a00c 100644
--- a/src/controllers/dlgprefcontrollers.cpp
+++ b/src/controllers/dlgprefcontrollers.cpp
@@ -19,6 +19,8 @@ DlgPrefControllers::DlgPrefControllers(DlgPreferences* pPreferences,
           m_pControllerManager(pControllerManager),
           m_pControllerTreeItem(pControllerTreeItem) {
     setupUi(this);
+    // Create text color for the cue mode link "?" to the manual
+    createLinkColor();
     setupControllerWidgets();
 
     const QString presetsPath = userPresetsPath(m_pConfig);
diff --git a/src/preferences/dialog/dlgprefdeck.cpp b/src/preferences/dialog/dlgprefdeck.cpp
index 8c943fa276..ead1084ea6 100644
--- a/src/preferences/dialog/dlgprefdeck.cpp
+++ b/src/preferences/dialog/dlgprefdeck.cpp
@@ -50,6 +50,8 @@ DlgPrefDeck::DlgPrefDeck(QWidget* parent,
           m_iNumConfiguredDecks(0),
           m_iNumConfiguredSamplers(0) {
     setupUi(this);
+    // Create text color for the cue mode link "?" to the manual
+    createLinkColor();
 
     m_pNumDecks->connectValueChanged(this, [=](double value){slotNumDecksChanged(value);});
     slotNumDecksChanged(m_pNumDecks->get(), true);
diff --git a/src/preferences/dialog/dlgprefmodplug.cpp b/src/preferences/dialog/dlgprefmodplug.cpp
index d4ed76f8cd..1cd86c8822 100644
--- a/src/preferences/dialog/dlgprefmodplug.cpp
+++ b/src/preferences/dialog/dlgprefmodplug.cpp
@@ -16,6 +16,8 @@ DlgPrefModplug::DlgPrefModplug(QWidget *parent,
           m_pUi(new Ui::DlgPrefModplug),
           m_pConfig(_config) {
     m_pUi->setupUi(this);
+    // Create text color for the OpenMTP manual link
+    createLinkColor();
     m_pUi->advancedSettings->setVisible(m_pUi->showAdvanced->isChecked());
 
     connect(m_pUi->memoryLimit,
diff --git a/src/preferences/dialog/dlgprefnovinyl.cpp b/src/preferences/dialog/dlgprefnovinyl.cpp
index 94eb893aee..e6497bfa3a 100644
--- a/src/preferences/dialog/dlgprefnovinyl.cpp
+++ b/src/preferences/dialog/dlgprefnovinyl.cpp
@@ -11,7 +11,11 @@ DlgPrefNoVinyl::DlgPrefNoVinyl(QWidget * parent, SoundManager * soundman,
     Q_UNUSED(soundman);
     Q_UNUSED(_config);
     setupUi(this);
+    // Create text color for the cue mode link "?" to the manual
+    createLinkColor();
     noVinylControlHint->setText(
+            // TODO That link is kinda pointless as it does not clarify
+            // why VC is not available
             tr("This version of Mixxx does not support vinyl control.\n"
                "Please visit %1 for more information.")
                     .arg(coloredLinkString(
diff --git a/src/preferences/dialog/dlgprefsound.cpp b/src/preferences/dialog/dlgprefsound.cpp
index e0baf65b7d..2d6358d7d8 100644
--- a/src/preferences/dialog/dlgprefsound.cpp
+++ b/src/preferences/dialog/dlgprefsound.cpp
@@ -29,6 +29,8 @@ DlgPrefSound::DlgPrefSound(QWidget* pParent,
           m_bSkipConfigClear(true),
           m_loading(false) {
     setupUi(this);
+    // Create text color for the wiki links
+    createLinkColor();
 
     connect(m_pSoundManager, &SoundManager::devicesUpdated, this, &DlgPrefSound::refreshDevices);
 
diff --git a/src/preferences/dialog/dlgprefvinyl.cpp b/src/preferences/dialog/dlgprefvinyl.cpp
index 1a12984ad2..30413fb8f1 100644
--- a/src/preferences/dialog/dlgprefvinyl.cpp
+++ b/src/preferences/dialog/dlgprefvinyl.cpp
@@ -20,6 +20,8 @@ DlgPrefVinyl::DlgPrefVinyl(QWidget * parent, VinylControlManager *pVCMan,
     m_pNumDecks->connectValueChanged(this, &DlgPrefVinyl::slotNumDecksChanged);
 
     setupUi(this);
+    // Create text color for the Troubleshooting link
+    createLinkColor();
 
     delete groupBoxSignalQuality->layout();
     QHBoxLayout *layout = new QHBoxLayout;
diff --git a/src/preferences/dlgpreferencepage.cpp b/src/preferences/dlgpreferencepage.cpp
index f316655bc4..61b912b441 100644
--- a/src/preferences/dlgpreferencepage.cpp
+++ b/src/preferences/dlgpreferencepage.cpp
@@ -5,7 +5,6 @@
 
 DlgPreferencePage::DlgPreferencePage(QWidget* pParent)
         : QWidget(pParent) {
-    createLinkColor();
 }
 
 DlgPreferencePage::~DlgPreferencePage() {
diff --git a/src/preferences/dlgpreferencepage.h b/src/preferences/dlgpreferencepage.h
index d2a06a2515..7e8134eca8 100644
--- a/src/preferences/dlgpreferencepage.h
+++ b/src/preferences/dlgpreferencepage.h
@@ -49,7 +49,7 @@ class DlgPreferencePage : public QWidget {
     /// Called when the preferences dialog is hidden from the user.
     virtual void slotHide() {}
 
-  private:
+    // Supply a readable text color for all file and website links
     inline void createLinkColor() {
         // Blend the palette colors for regular text and link text to get a color
         // that is more likely to be visible with dark OS themes.