diff options
| author | Sean M. Pappalardo <spappalardo@mixxx.org> | 2015-12-17 16:27:46 -0800 |
|---|---|---|
| committer | Sean M. Pappalardo <spappalardo@mixxx.org> | 2015-12-17 16:27:46 -0800 |
| commit | 469a37f11239b8c700fac98ad5d78d0299f934c2 (patch) | |
| tree | d39ae0000007062e439cce7e8a583312ff7f4420 /src | |
| parent | 5b9ea4f7099996f45ab36b31358560b2caa68b35 (diff) | |
Increase number of MIDI messages to buffer, fix bug #1527410
Chatty MIDI controllers like the Stanton SCS.1d (moving platter) can queue up a large number of messages if the system is for whatever reason slow to respond to them. If more than this number queue up, Mixxx stops responding to that controller. Experimental stress-testing showed 500 messages at once in the queue (during stupid things like application window switching, but still.)
This may not be the best fix, but it's quick and breaks nothing for the 2.0 release.
Diffstat (limited to 'src')
| -rw-r--r-- | src/controllers/midi/portmidicontroller.h | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/src/controllers/midi/portmidicontroller.h b/src/controllers/midi/portmidicontroller.h index 734777e994..628f08e112 100644 --- a/src/controllers/midi/portmidicontroller.h +++ b/src/controllers/midi/portmidicontroller.h @@ -20,7 +20,9 @@ #include <portmidi.h> #include "controllers/midi/midicontroller.h" -#define MIXXX_PORTMIDI_BUFFER_LEN 64 /**Number of MIDI messages to buffer*/ +// Mixxx completely stops responding to the controller if more than this number of messages queue up. +// Don't lower this (much.) The SCS.1d accumulated 500 messages in a single poll during stress-testing. +#define MIXXX_PORTMIDI_BUFFER_LEN 1024 /**Number of MIDI messages to buffer*/ #define MIXXX_PORTMIDI_NO_DEVICE_STRING "None" /**String to display for no MIDI devices present */ /** A PortMidi-based implementation of MidiController */ |