Pref. EQ, WEffectSelector: update combobox comments

2 files changed, 10 insertions, 8 deletions

diff --git a/src/preferences/dialog/dlgprefeq.cpp b/src/preferences/dialog/dlgprefeq.cpp
index ee8b0fd825..a001d13a78 100644
--- a/src/preferences/dialog/dlgprefeq.cpp
+++ b/src/preferences/dialog/dlgprefeq.cpp
@@ -225,11 +225,12 @@ void DlgPrefEQ::slotPopulateDeckEffectSelectors() {
                 currentIndex = i;
             }
         }
-        //: Displayed when no effect is selected
+        // Add empty item, no effect
         box->addItem(EffectsManager::kNoEffectString);
 
         if (selectedEffectId.isEmpty()) {
-            currentIndex = availableEQEffects.size(); // Discards the current selection
+            // Configured effect has no id, clear selection
+            currentIndex = availableEQEffects.size();
         } else if (currentIndex < 0 && !selectedEffectName.isEmpty() ) {
             // current selection is not part of the new list
             // So we need to add it
@@ -255,11 +256,12 @@ void DlgPrefEQ::slotPopulateDeckEffectSelectors() {
                 currentIndex = i;
             }
         }
-        //: Displayed when no effect is selected
+        // Add empty item, no effect
         box->addItem(EffectsManager::kNoEffectString);
 
         if (selectedEffectId.isEmpty()) {
-            currentIndex = availableQuickEffects.size(); // Discards the current selection
+            // Configured effect has no id, clear selection
+            currentIndex = availableQuickEffects.size();
         } else if (currentIndex < 0 && !selectedEffectName.isEmpty()) {
             // current selection is not part of the new list
             // So we need to add it
@@ -673,12 +675,13 @@ void DlgPrefEQ::setUpMasterEQ() {
     for (const auto& pManifest : availableMasterEQEffects) {
         comboBoxMasterEq->addItem(pManifest->name(), QVariant(pManifest->id()));
     }
-    //: Displayed when no effect is selected
+    // Add empty item, no effect
     comboBoxMasterEq->addItem(EffectsManager::kNoEffectString);
 
     int masterEqIndex = comboBoxMasterEq->findData(configuredEffect);
     if (masterEqIndex < 0) {
-        masterEqIndex = availableMasterEQEffects.size(); // Discards the current selection
+        // Configured effect not in list, clear selection
+        masterEqIndex = availableMasterEQEffects.size();
     }
     comboBoxMasterEq->setCurrentIndex(masterEqIndex);
 
diff --git a/src/widget/weffectselector.cpp b/src/widget/weffectselector.cpp
index 99c9f0a441..4480ef0301 100644
--- a/src/widget/weffectselector.cpp
+++ b/src/widget/weffectselector.cpp
@@ -71,8 +71,7 @@ void WEffectSelector::populate() {
         setItemData(i, QVariant(QStringLiteral("<b>") + name + QStringLiteral("</b><br/>") +
                 description), Qt::ToolTipRole);
     }
-
-    //: Displayed when no effect is loaded
+    // Add empty item, no effect
     addItem(EffectsManager::kNoEffectString);
     setItemData(visibleEffectManifests.size(), QVariant(tr("No effect loaded.")),
                 Qt::ToolTipRole);