Do not pass RgbColor/RgbColor::optional_t by reference

8 files changed, 12 insertions, 12 deletions

diff --git a/src/track/cue.cpp b/src/track/cue.cpp
index 286d2269aa..45e3ec3e2e 100644
--- a/src/track/cue.cpp
+++ b/src/track/cue.cpp
@@ -165,7 +165,7 @@ mixxx::RgbColor Cue::getColor() const {
     return m_color;
 }
 
-void Cue::setColor(const mixxx::RgbColor& color) {
+void Cue::setColor(const mixxx::RgbColor color) {
     QMutexLocker lock(&m_mutex);
     m_color = color;
     m_bDirty = true;
diff --git a/src/track/cue.h b/src/track/cue.h
index cf86b4393d..6846041b70 100644
--- a/src/track/cue.h
+++ b/src/track/cue.h
@@ -55,7 +55,7 @@ class Cue : public QObject {
     void setLabel(QString label);
 
     mixxx::RgbColor getColor() const;
-    void setColor(const mixxx::RgbColor& color);
+    void setColor(const mixxx::RgbColor color);
 
     double getEndPosition() const;
 
diff --git a/src/widget/wcolorpicker.cpp b/src/widget/wcolorpicker.cpp
index 8b3bcf75b4..8d7b8cb2ae 100644
--- a/src/widget/wcolorpicker.cpp
+++ b/src/widget/wcolorpicker.cpp
@@ -79,7 +79,7 @@ WColorPicker::WColorPicker(ColorOption colorOption, const ColorPalette& palette,
     }
 }
 
-void WColorPicker::addColorButton(const mixxx::RgbColor::optional_t& color, QGridLayout* pLayout, int row, int column) {
+void WColorPicker::addColorButton(const mixxx::RgbColor::optional_t color, QGridLayout* pLayout, int row, int column) {
     setLayout(pLayout);
     parented_ptr<QPushButton> pColorButton = make_parented<QPushButton>("", this);
     if (m_pStyle) {
@@ -141,7 +141,7 @@ void WColorPicker::resetSelectedColor() {
     pButton->style()->polish(pButton);
 }
 
-void WColorPicker::setSelectedColor(const mixxx::RgbColor::optional_t& color) {
+void WColorPicker::setSelectedColor(const mixxx::RgbColor::optional_t color) {
     resetSelectedColor();
 
     m_selectedColor = color;
@@ -194,6 +194,6 @@ void WColorPicker::useColorSet(const ColorPalette& palette) {
     }
 }
 
-void WColorPicker::slotColorPicked(const mixxx::RgbColor::optional_t& color) {
+void WColorPicker::slotColorPicked(const mixxx::RgbColor::optional_t color) {
     setSelectedColor(color);
 }
diff --git a/src/widget/wcolorpicker.h b/src/widget/wcolorpicker.h
index f43419c425..671be786b0 100644
--- a/src/widget/wcolorpicker.h
+++ b/src/widget/wcolorpicker.h
@@ -20,17 +20,17 @@ class WColorPicker : public QWidget {
     explicit WColorPicker(ColorOption colorOption, const ColorPalette& palette, QWidget* parent = nullptr);
 
     void resetSelectedColor();
-    void setSelectedColor(const mixxx::RgbColor::optional_t& color);
+    void setSelectedColor(const mixxx::RgbColor::optional_t color);
     void useColorSet(const ColorPalette& palette);
 
   signals:
     void colorPicked(mixxx::RgbColor::optional_t color);
 
   private slots:
-    void slotColorPicked(const mixxx::RgbColor::optional_t& color);
+    void slotColorPicked(const mixxx::RgbColor::optional_t color);
 
   private:
-    void addColorButton(const mixxx::RgbColor::optional_t& color, QGridLayout* pLayout, int row, int column);
+    void addColorButton(const mixxx::RgbColor::optional_t color, QGridLayout* pLayout, int row, int column);
     ColorOption m_colorOption;
     mixxx::RgbColor::optional_t m_selectedColor;
     ColorPalette m_palette;
diff --git a/src/widget/wcuemenupopup.cpp b/src/widget/wcuemenupopup.cpp
index 1d9dea71b0..0d21dcdc8e 100644
--- a/src/widget/wcuemenupopup.cpp
+++ b/src/widget/wcuemenupopup.cpp
@@ -110,7 +110,7 @@ void WCueMenuPopup::slotEditLabel() {
     m_pCue->setLabel(m_pEditLabel->text());
 }
 
-void WCueMenuPopup::slotChangeCueColor(const mixxx::RgbColor::optional_t& color) {
+void WCueMenuPopup::slotChangeCueColor(const mixxx::RgbColor::optional_t color) {
     VERIFY_OR_DEBUG_ASSERT(m_pCue != nullptr) {
         return;
     }
diff --git a/src/widget/wcuemenupopup.h b/src/widget/wcuemenupopup.h
index 9338783c76..e052b948de 100644
--- a/src/widget/wcuemenupopup.h
+++ b/src/widget/wcuemenupopup.h
@@ -54,7 +54,7 @@ class WCueMenuPopup : public QWidget {
   private slots:
     void slotEditLabel();
     void slotDeleteCue();
-    void slotChangeCueColor(const mixxx::RgbColor::optional_t& color);
+    void slotChangeCueColor(const mixxx::RgbColor::optional_t color);
 
   private:
     CuePointer m_pCue;
diff --git a/src/widget/wtracktableview.cpp b/src/widget/wtracktableview.cpp
index 2bbf3895d1..562658d860 100644
--- a/src/widget/wtracktableview.cpp
+++ b/src/widget/wtracktableview.cpp
@@ -1972,7 +1972,7 @@ void WTrackTableView::lockBpm(bool lock) {
     }
 }
 
-void WTrackTableView::slotColorPicked(const mixxx::RgbColor::optional_t& color) {
+void WTrackTableView::slotColorPicked(const mixxx::RgbColor::optional_t color) {
     TrackModel* trackModel = getTrackModel();
     if (trackModel == nullptr) {
         return;
diff --git a/src/widget/wtracktableview.h b/src/widget/wtracktableview.h
index ef22de8080..03cb8c3cf3 100644
--- a/src/widget/wtracktableview.h
+++ b/src/widget/wtracktableview.h
@@ -81,7 +81,7 @@ class WTrackTableView : public WLibraryTableView {
     void slotLockBpm();
     void slotUnlockBpm();
     void slotScaleBpm(int);
-    void slotColorPicked(const mixxx::RgbColor::optional_t& color);
+    void slotColorPicked(const mixxx::RgbColor::optional_t color);
 
     void slotClearBeats();
     void slotClearPlayCount();