diff options
author | Jan Holthuis <jan.holthuis@ruhr-uni-bochum.de> | 2020-03-01 22:11:35 +0100 |
---|---|---|
committer | Jan Holthuis <jan.holthuis@ruhr-uni-bochum.de> | 2020-03-01 23:27:41 +0100 |
commit | 8d3672390c77b1199171517422149f623ab00d6a (patch) | |
tree | 696fc2d77d8f6262fdac81ec27d9d006b3b5e151 /src/widget/wtracktableview.cpp | |
parent | 6841da634a754e68d5c8abf49ef18b3b38c51c7a (diff) | |
parent | 99bfeef3020ce6469f79c7a377965244d15add35 (diff) |
Merge branch 'master' of github.com:mixxxdj/mixxx into hotcue-rgb-colors
Diffstat (limited to 'src/widget/wtracktableview.cpp')
-rw-r--r-- | src/widget/wtracktableview.cpp | 36 |
1 files changed, 18 insertions, 18 deletions
diff --git a/src/widget/wtracktableview.cpp b/src/widget/wtracktableview.cpp index f2e0e40b75..e365192068 100644 --- a/src/widget/wtracktableview.cpp +++ b/src/widget/wtracktableview.cpp @@ -600,11 +600,9 @@ void WTrackTableView::slotMouseDoubleClicked(const QModelIndex &index) { } TrackPointer pTrack = trackModel->getTrack(index); - VERIFY_OR_DEBUG_ASSERT(pTrack) { - return; + if (pTrack) { + emit loadTrack(pTrack); } - - emit loadTrack(pTrack); } else if (doubleClickAction == DlgPrefLibrary::ADD_TO_AUTODJ_BOTTOM && modelHasCapabilities(TrackModel::TRACKMODELCAPS_ADDTOAUTODJ)) { addToAutoDJ(PlaylistDAO::AutoDJSendLoc::BOTTOM); @@ -1946,13 +1944,11 @@ void WTrackTableView::slotScaleBpm(int scale) { const QModelIndexList selectedTrackIndices = selectionModel()->selectedRows(); for (const auto& index : selectedTrackIndices) { - TrackPointer track = trackModel->getTrack(index); - if (!track->isBpmLocked()) { // bpm is not locked - BeatsPointer beats = track->getBeats(); - if (beats != nullptr) { - beats->scale(static_cast<Beats::BPMScale>(scale)); - } else { - continue; + TrackPointer pTrack = trackModel->getTrack(index); + if (pTrack && !pTrack->isBpmLocked()) { + BeatsPointer pBeats = pTrack->getBeats(); + if (pBeats) { + pBeats->scale(static_cast<Beats::BPMScale>(scale)); } } } @@ -1967,8 +1963,10 @@ void WTrackTableView::lockBpm(bool lock) { const QModelIndexList selectedTrackIndices = selectionModel()->selectedRows(); // TODO: This should be done in a thread for large selections for (const auto& index : selectedTrackIndices) { - TrackPointer track = trackModel->getTrack(index); - track->setBpmLocked(lock); + TrackPointer pTrack = trackModel->getTrack(index); + if (pTrack) { + pTrack->setBpmLocked(lock); + } } } @@ -1981,8 +1979,10 @@ void WTrackTableView::slotColorPicked(mixxx::RgbColor::optional_t color) { const QModelIndexList selectedTrackIndices = selectionModel()->selectedRows(); // TODO: This should be done in a thread for large selections for (const auto& index : selectedTrackIndices) { - TrackPointer track = trackModel->getTrack(index); - track->setColor(color); + TrackPointer pTrack = trackModel->getTrack(index); + if (pTrack) { + pTrack->setColor(color); + } } m_pMenu->hide(); @@ -1997,9 +1997,9 @@ void WTrackTableView::slotClearBeats() { const QModelIndexList selectedTrackIndices = selectionModel()->selectedRows(); // TODO: This should be done in a thread for large selections for (const auto& index : selectedTrackIndices) { - TrackPointer track = trackModel->getTrack(index); - if (!track->isBpmLocked()) { - track->setBeats(BeatsPointer()); + TrackPointer pTrack = trackModel->getTrack(index); + if (pTrack && !pTrack->isBpmLocked()) { + pTrack->setBeats(BeatsPointer()); } } } |