summaryrefslogtreecommitdiffstats
path: root/src/sources
diff options
context:
space:
mode:
authorUwe Klotz <uklotz@mixxx.org>2021-01-16 10:20:27 +0100
committerUwe Klotz <uklotz@mixxx.org>2021-01-16 10:23:56 +0100
commitd36733234fc56539a0a37e1d94bf5b053f792d4e (patch)
treebad5b718b4d2d2b05184ec9e5cf9d1f5be3a2ee6 /src/sources
parent35f67caf121e7a9277f5324d97f4e7535a898dd4 (diff)
Disable decoding of OGG files for libsndfile-1.0.30
Diffstat (limited to 'src/sources')
-rw-r--r--src/sources/soundsourcesndfile.cpp7
1 files changed, 1 insertions, 6 deletions
diff --git a/src/sources/soundsourcesndfile.cpp b/src/sources/soundsourcesndfile.cpp
index 032c12b08f..cd0f07c39c 100644
--- a/src/sources/soundsourcesndfile.cpp
+++ b/src/sources/soundsourcesndfile.cpp
@@ -23,22 +23,17 @@ const QStringList kSupportedFileExtensions = {
};
// SoundSourceProxyTest fails for version 1.0.30 and OGG files
-#if defined(__APPLE__)
+// https://github.com/libsndfile/libsndfile/issues/643
const QLatin1String kVersionStringWithBrokenOggDecoding = QLatin1String("libsndfile-1.0.30");
-#endif
QStringList getSupportedFileExtensionsFiltered() {
auto supportedFileExtensions = kSupportedFileExtensions;
- // Until now this issue was only confirmed for macOS and libsndfile
- // installed from Homebrew during the SCons build on Travis CI.
-#if defined(__APPLE__)
if (sf_version_string() == kVersionStringWithBrokenOggDecoding) {
kLogger.info()
<< "Disabling OGG decoding for"
<< kVersionStringWithBrokenOggDecoding;
supportedFileExtensions.removeAll(QStringLiteral("ogg"));
}
-#endif
return supportedFileExtensions;
};