Merge remote-tracking branch 'upstream/2.4' into mainmain

1 files changed, 2 insertions, 5 deletions

diff --git a/src/library/baseexternallibraryfeature.h b/src/library/baseexternallibraryfeature.h
index 0bae9ec668..ee5faf8f7d 100644
--- a/src/library/baseexternallibraryfeature.h
+++ b/src/library/baseexternallibraryfeature.h
@@ -27,12 +27,9 @@ class BaseExternalLibraryFeature : public LibraryFeature {
     void onRightClickChild(const QPoint& globalPos, const QModelIndex& index) override;
 
   protected:
-    // Must be implemented by external Libraries copied to Mixxx DB
+    // Must be re-implemented by external Libraries copied to Mixxx DB
     virtual std::unique_ptr<BaseSqlTableModel> createPlaylistModelForPlaylist(
-            const QString& playlist) {
-        Q_UNUSED(playlist);
-        return {};
-    }
+            const QString& playlist);
     // Must be implemented by external Libraries not copied to Mixxx DB
     virtual void appendTrackIdsFromRightClickIndex(QList<TrackId>* trackIds, QString* pPlaylist);