diff options
| author | Stéphane Lepin <stephane.lepin@gmail.com> | 2019-01-08 23:01:44 +0100 |
|---|---|---|
| committer | Stéphane Lepin <stephane.lepin@gmail.com> | 2019-01-08 23:01:44 +0100 |
| commit | bf76efab5f01d0ddb2d103ccd137c6cb87c068f3 (patch) | |
| tree | 96eec0057e74cd78a04f518addd74ebb69c19b38 /src/encoder | |
| parent | 175ee31376bf74de648b7d7acbe0fa17259ff227 (diff) | |
encoderopussettings: fix minor issues
Diffstat (limited to 'src/encoder')
| -rw-r--r-- | src/encoder/encoderopussettings.cpp | 7 | ||||
| -rw-r--r-- | src/encoder/encoderopussettings.h | 4 |
2 files changed, 4 insertions, 7 deletions
diff --git a/src/encoder/encoderopussettings.cpp b/src/encoder/encoderopussettings.cpp index ec47fda2ce..19a462c9d6 100644 --- a/src/encoder/encoderopussettings.cpp +++ b/src/encoder/encoderopussettings.cpp @@ -45,9 +45,6 @@ EncoderOpusSettings::EncoderOpusSettings(UserSettingsPointer pConfig) QObject::tr("Bitrate Mode"), BITRATE_MODE_GROUP, modes.values())); } -EncoderOpusSettings::~EncoderOpusSettings() { -} - QList<int> EncoderOpusSettings::getQualityValues() const { return m_qualList; } @@ -108,7 +105,7 @@ QList<EncoderSettings::OptionsGroup> EncoderOpusSettings::getOptionGroups() cons void EncoderOpusSettings::setGroupOption(QString groupCode, int optionIndex) { bool found = false; - for (OptionsGroup group : m_radioList) { + for (OptionsGroup group : qAsConst(m_radioList)) { if (groupCode == group.groupCode) { found = true; if (optionIndex < group.controlNames.size() || optionIndex == 1) { @@ -134,7 +131,7 @@ int EncoderOpusSettings::getSelectedOption(QString groupCode) const { ConfigKey(RECORDING_PREF_KEY, BITRATE_MODE_GROUP), 0); bool found = false; - for (OptionsGroup group : m_radioList) { + for (OptionsGroup group : qAsConst(m_radioList)) { if (groupCode == group.groupCode) { found = true; if (value >= group.controlNames.size() && value > 1) { diff --git a/src/encoder/encoderopussettings.h b/src/encoder/encoderopussettings.h index 576e4efc66..adc4210ae9 100644 --- a/src/encoder/encoderopussettings.h +++ b/src/encoder/encoderopussettings.h @@ -14,8 +14,8 @@ class EncoderOpusSettings: public EncoderSettings { public: - EncoderOpusSettings(UserSettingsPointer pConfig); - virtual ~EncoderOpusSettings(); + explicit EncoderOpusSettings(UserSettingsPointer pConfig); + ~EncoderOpusSettings() override = default; // Indicates that it uses the quality slider section of the preferences bool usesQualitySlider() const override { |