Fix error prone recording settings prefs design

6 files changed, 0 insertions, 31 deletions

diff --git a/src/encoder/encoderflacsettings.h b/src/encoder/encoderflacsettings.h
index 83d640acf3..2f01623be4 100644
--- a/src/encoder/encoderflacsettings.h
+++ b/src/encoder/encoderflacsettings.h
@@ -19,8 +19,6 @@ class EncoderFlacSettings : public EncoderRecordingSettings {
 
     // Indicates that it uses the compression slider section of the preferences
     bool usesCompressionSlider() const override;
-    // Indicates that it uses the radio button section of the preferences.
-    bool usesOptionGroups() const override;
 
     // Returns the list of compression values supported, to assign them to the slider
     virtual QList<int> getCompressionValues() const override;
@@ -50,10 +48,5 @@ class EncoderFlacSettings : public EncoderRecordingSettings {
     UserSettingsPointer m_pConfig;
 };
 
-inline bool EncoderFlacSettings::usesOptionGroups() const
-{
-    return true;
-}
-
 #endif // ENCODERFLACSETTINGS_H
 
diff --git a/src/encoder/encodermp3settings.h b/src/encoder/encodermp3settings.h
index be50505fa7..9ddb310db2 100644
--- a/src/encoder/encodermp3settings.h
+++ b/src/encoder/encodermp3settings.h
@@ -21,10 +21,6 @@ class EncoderMp3Settings : public EncoderRecordingSettings {
     bool usesQualitySlider() const override {
         return true;
     }
-    // Indicates that it uses the radio button section of the preferences.
-    bool usesOptionGroups() const override {
-        return true;
-    }
     // Returns the list of quality values that it supports, to assign them to the slider
     QList<int> getQualityValues() const override;
     QList<int> getVBRQualityValues() const;
diff --git a/src/encoder/encoderopussettings.h b/src/encoder/encoderopussettings.h
index 232b92c34c..c9e06a969d 100644
--- a/src/encoder/encoderopussettings.h
+++ b/src/encoder/encoderopussettings.h
@@ -23,11 +23,6 @@ class EncoderOpusSettings: public EncoderRecordingSettings {
         return true;
     }
 
-    // Indicates that it uses the radio button section of the preferences.
-    bool usesOptionGroups() const override {
-        return true;
-    }
-
     // Returns the list of quality values that it supports, to assign them to the slider
     QList<int> getQualityValues() const override;
     // Sets the quality value by its index
diff --git a/src/encoder/encoderrecordingsettings.h b/src/encoder/encoderrecordingsettings.h
index 6ea1b69c5d..3756ab68be 100644
--- a/src/encoder/encoderrecordingsettings.h
+++ b/src/encoder/encoderrecordingsettings.h
@@ -17,11 +17,6 @@ class EncoderRecordingSettings : public EncoderSettings {
         return false;
     }
 
-    // Indicates that it uses the radio button section of the preferences.
-    virtual bool usesOptionGroups() const {
-        return false;
-    }
-
     virtual void setQualityByIndex(int qualityIndex) {
         Q_UNUSED(qualityIndex);
         DEBUG_ASSERT(!"unimplemented");
diff --git a/src/encoder/encodervorbissettings.h b/src/encoder/encodervorbissettings.h
index 6cc7332b6c..920ee85273 100644
--- a/src/encoder/encodervorbissettings.h
+++ b/src/encoder/encodervorbissettings.h
@@ -22,11 +22,6 @@ class EncoderVorbisSettings : public EncoderRecordingSettings {
         return true;
     }
 
-    // Indicates that it uses the radio button section of the preferences.
-    bool usesOptionGroups() const override{
-        return true;
-    }
-
     // Returns the list of quality values that it supports, to assign them to the slider
     QList<int> getQualityValues() const override;
     // Sets the quality value by its index
diff --git a/src/encoder/encoderwavesettings.h b/src/encoder/encoderwavesettings.h
index 2051eca98f..1880c9a4bd 100644
--- a/src/encoder/encoderwavesettings.h
+++ b/src/encoder/encoderwavesettings.h
@@ -17,11 +17,6 @@ class EncoderWaveSettings : public EncoderRecordingSettings {
     EncoderWaveSettings(UserSettingsPointer pConfig, QString format);
     virtual ~EncoderWaveSettings();
 
-    // Indicates that it uses the radio button section of the preferences.
-    bool usesOptionGroups() const override {
-        return true;
-    }
-
     // Returns the list of radio options to show to the user
     QList<OptionsGroup> getOptionGroups() const override;
     // Selects the option by its index. If it is a single-element option,