diff options
author | Theodore Ts'o <tytso@mit.edu> | 2014-08-23 17:47:28 -0400 |
---|---|---|
committer | Theodore Ts'o <tytso@mit.edu> | 2014-08-23 17:47:28 -0400 |
commit | c99d1e6e83b06744c75d9f5e491ed495a7086b7b (patch) | |
tree | 10700ad60c0dd5cf5f648be2f732a54fd7fe2ae5 /virt | |
parent | 36de928641ee48b2078d3fe9514242aaa2f92013 (diff) |
ext4: fix BUG_ON in mb_free_blocks()
If we suffer a block allocation failure (for example due to a memory
allocation failure), it's possible that we will call
ext4_discard_allocated_blocks() before we've actually allocated any
blocks. In that case, fe_len and fe_start in ac->ac_f_ex will still
be zero, and this will result in mb_free_blocks(inode, e4b, 0, 0)
triggering the BUG_ON on mb_free_blocks():
BUG_ON(last >= (sb->s_blocksize << 3));
Fix this by bailing out of ext4_discard_allocated_blocks() if fs_len
is zero.
Also fix a missing ext4_mb_unload_buddy() call in
ext4_discard_allocated_blocks().
Google-Bug-Id: 16844242
Fixes: 86f0afd463215fc3e58020493482faa4ac3a4d69
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Cc: stable@vger.kernel.org
Diffstat (limited to 'virt')
0 files changed, 0 insertions, 0 deletions