summaryrefslogtreecommitdiffstats
path: root/virt
diff options
context:
space:
mode:
authorFelipe Franciosi <felipe@nutanix.com>2020-05-19 08:11:22 +0000
committerPaolo Bonzini <pbonzini@redhat.com>2020-06-11 12:35:18 -0400
commit384dea1c9183880be183cfaae161d99aafd16df6 (patch)
tree9f6acf93b84ce4a5867bc3c08f69507583b0549d /virt
parent7e464770a434f7e29bad4b2da7894d32775d6d6f (diff)
KVM: x86: respect singlestep when emulating instruction
When userspace configures KVM_GUESTDBG_SINGLESTEP, KVM will manage the presence of X86_EFLAGS_TF via kvm_set/get_rflags on vcpus. The actual rflag bit is therefore hidden from callers. That includes init_emulate_ctxt() which uses the value returned from kvm_get_flags() to set ctxt->tf. As a result, x86_emulate_instruction() will skip a single step, leaving singlestep_rip stale and not returning to userspace. This resolves the issue by observing the vcpu guest_debug configuration alongside ctxt->tf in x86_emulate_instruction(), performing the single step if set. Cc: stable@vger.kernel.org Signed-off-by: Felipe Franciosi <felipe@nutanix.com> Message-Id: <20200519081048.8204-1-felipe@nutanix.com> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Diffstat (limited to 'virt')
0 files changed, 0 insertions, 0 deletions