summaryrefslogtreecommitdiffstats
path: root/usr
diff options
context:
space:
mode:
authorJeff Dike <jdike@akamai.com>2020-12-22 21:54:21 -0500
committerJakub Kicinski <kuba@kernel.org>2020-12-23 09:11:13 -0800
commitde33212f768c5d9e2fe791b008cb26f92f0aa31c (patch)
treef4162dcbcc990e5c4a452f4fdaac2d87e659103a /usr
parente77c725a445ac07c95c666b3bfb5b4105e9b0068 (diff)
virtio_net: Fix recursive call to cpus_read_lock()
virtnet_set_channels can recursively call cpus_read_lock if CONFIG_XPS and CONFIG_HOTPLUG are enabled. The path is: virtnet_set_channels - calls get_online_cpus(), which is a trivial wrapper around cpus_read_lock() netif_set_real_num_tx_queues netif_reset_xps_queues_gt netif_reset_xps_queues - calls cpus_read_lock() This call chain and potential deadlock happens when the number of TX queues is reduced. This commit the removes netif_set_real_num_[tr]x_queues calls from inside the get/put_online_cpus section, as they don't require that it be held. Fixes: 47be24796c13 ("virtio-net: fix the set affinity bug when CPU IDs are not consecutive") Signed-off-by: Jeff Dike <jdike@akamai.com> Acked-by: Jason Wang <jasowang@redhat.com> Acked-by: Michael S. Tsirkin <mst@redhat.com> Link: https://lore.kernel.org/r/20201223025421.671-1-jdike@akamai.com Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Diffstat (limited to 'usr')
0 files changed, 0 insertions, 0 deletions