summaryrefslogtreecommitdiffstats
path: root/samples/livepatch
diff options
context:
space:
mode:
authorMaxim Mikityanskiy <maximmi@mellanox.com>2020-08-17 16:34:07 +0300
committerDavid S. Miller <davem@davemloft.net>2020-08-18 16:00:24 -0700
commitf01204ec8be7ea5e8f0230a7d4200e338d563bde (patch)
treefb5e16276b5e28593b6fc0890a663ab0bbeb72d0 /samples/livepatch
parent2847bfed888fbb8bf4c8e8067fd6127538c2c700 (diff)
ethtool: Don't omit the netlink reply if no features were changed
The legacy ethtool userspace tool shows an error when no features could be changed. It's useful to have a netlink reply to be able to show this error when __netdev_update_features wasn't called, for example: 1. ethtool -k eth0 large-receive-offload: off 2. ethtool -K eth0 rx-fcs on 3. ethtool -K eth0 lro on Could not change any device features rx-lro: off [requested on] 4. ethtool -K eth0 lro on # The output should be the same, but without this patch the kernel # doesn't send the reply, and ethtool is unable to detect the error. This commit makes ethtool-netlink always return a reply when requested, and it still avoids unnecessary calls to __netdev_update_features if the wanted features haven't changed. Fixes: 0980bfcd6954 ("ethtool: set netdev features with FEATURES_SET request") Signed-off-by: Maxim Mikityanskiy <maximmi@mellanox.com> Reviewed-by: Michal Kubecek <mkubecek@suse.cz> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'samples/livepatch')
0 files changed, 0 insertions, 0 deletions