diff options
author | David Ahern <dsahern@gmail.com> | 2019-05-01 18:18:42 -0700 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2019-05-04 00:38:53 -0400 |
commit | 4b2a2bfeb3f056461a90bd621e8bd7d03fa47f60 (patch) | |
tree | bea0822c13d5c2845b82d8923dfcb1fe2f58d887 /net/sched | |
parent | 64c6f4bbca748c3b2101469a76d88b7cd1c00476 (diff) |
neighbor: Call __ipv4_neigh_lookup_noref in neigh_xmit
Commit cd9ff4de0107 changed the key for IFF_POINTOPOINT devices to
INADDR_ANY but neigh_xmit which is used for MPLS encapsulations was not
updated to use the altered key. The result is that every packet Tx does
a lookup on the gateway address which does not find an entry, a new one
is created only to find the existing one in the table right before the
insert since arp_constructor was updated to reset the primary key. This
is seen in the allocs and destroys counters:
ip -s -4 ntable show | head -10 | grep alloc
which increase for each packet showing the unnecessary overhread.
Fix by having neigh_xmit use __ipv4_neigh_lookup_noref for NEIGH_ARP_TABLE.
Fixes: cd9ff4de0107 ("ipv4: Make neigh lookup keys for loopback/point-to-point devices be INADDR_ANY")
Reported-by: Alan Maguire <alan.maguire@oracle.com>
Signed-off-by: David Ahern <dsahern@gmail.com>
Tested-by: Alan Maguire <alan.maguire@oracle.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/sched')
0 files changed, 0 insertions, 0 deletions