diff options
author | Florian Westphal <fw@strlen.de> | 2018-11-15 10:22:59 +0100 |
---|---|---|
committer | Pablo Neira Ayuso <pablo@netfilter.org> | 2018-12-01 12:38:42 +0100 |
commit | 6ed5943f8735e2b778d92ea4d9805c0a1d89bc2b (patch) | |
tree | ad0b549420d6aeb8380dcc7ac6d1bbc7015b39f6 /net/netfilter/ipset | |
parent | c3e9305983597a61083482581e83f0bd77ba306a (diff) |
netfilter: nat: remove l4 protocol port rovers
This is a leftover from days where single-cpu systems were common:
Store last port used to resolve a clash to use it as a starting point when
the next conflict needs to be resolved.
When we have parallel attempt to connect to same address:port pair,
its likely that both cores end up computing the same "available" port,
as both use same starting port, and newly used ports won't become
visible to other cores until the conntrack gets confirmed later.
One of the cores then has to drop the packet at insertion time because
the chosen new tuple turns out to be in use after all.
Lets simplify this: remove port rover and use a pseudo-random starting
point.
Note that this doesn't make netfilter default to 'fully random' mode;
the 'rover' was only used if NAT could not reuse source port as-is.
Signed-off-by: Florian Westphal <fw@strlen.de>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
Diffstat (limited to 'net/netfilter/ipset')
0 files changed, 0 insertions, 0 deletions