summaryrefslogtreecommitdiffstats
path: root/init
diff options
context:
space:
mode:
authorGabriel Krisman Bertazi <krisman@collabora.com>2020-10-22 16:58:42 -0400
committerJens Axboe <axboe@kernel.dk>2020-10-26 07:57:47 -0600
commitf255c19b3ab46d3cad3b1b2e1036f4c926cb1d0c (patch)
tree7cfc8b4e2a8ad387349116137844b81e9264cb0b /init
parent52abfcbd57eefdd54737fc8c2dc79d8f46d4a3e5 (diff)
blk-cgroup: Pre-allocate tree node on blkg_conf_prep
Similarly to commit 457e490f2b741 ("blkcg: allocate struct blkcg_gq outside request queue spinlock"), blkg_create can also trigger occasional -ENOMEM failures at the radix insertion because any allocation inside blkg_create has to be non-blocking, making it more likely to fail. This causes trouble for userspace tools trying to configure io weights who need to deal with this condition. This patch reduces the occurrence of -ENOMEMs on this path by preloading the radix tree element on a GFP_KERNEL context, such that we guarantee the later non-blocking insertion won't fail. A similar solution exists in blkcg_init_queue for the same situation. Acked-by: Tejun Heo <tj@kernel.org> Signed-off-by: Gabriel Krisman Bertazi <krisman@collabora.com> Signed-off-by: Jens Axboe <axboe@kernel.dk>
Diffstat (limited to 'init')
0 files changed, 0 insertions, 0 deletions