diff options
author | Miklos Szeredi <mszeredi@redhat.com> | 2017-10-30 21:14:56 +0100 |
---|---|---|
committer | Jan Kara <jack@suse.cz> | 2017-10-31 17:54:56 +0100 |
commit | f37650f1c7c71cf5180b43229d13b421d81e7170 (patch) | |
tree | ff7aab8765170e57aaa8eb117b9c899017b02fe6 /fs/squashfs | |
parent | 9a31d7ad997f55768c687974ce36b759065b49e5 (diff) |
fanotify: fix fsnotify_prepare_user_wait() failure
If fsnotify_prepare_user_wait() fails, we leave the event on the
notification list. Which will result in a warning in
fsnotify_destroy_event() and later use-after-free.
Instead of adding a new helper to remove the event from the list in this
case, I opted to move the prepare/finish up into fanotify_handle_event().
This will allow these to be moved further out into the generic code later,
and perhaps let us move to non-sleeping RCU.
Reviewed-by: Amir Goldstein <amir73il@gmail.com>
Signed-off-by: Miklos Szeredi <mszeredi@redhat.com>
Fixes: 05f0e38724e8 ("fanotify: Release SRCU lock when waiting for userspace response")
Cc: <stable@vger.kernel.org> # v4.12
Signed-off-by: Jan Kara <jack@suse.cz>
Diffstat (limited to 'fs/squashfs')
0 files changed, 0 insertions, 0 deletions