diff options
| author | Roland Vossen <rvossen@broadcom.com> | 2011-10-04 23:19:12 +0200 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@suse.de> | 2011-10-05 13:39:05 -0700 |
| commit | d0f5527d3949db767425dc84f0e8547824b74708 (patch) | |
| tree | 1027dfacd0d360c1078b4ed102f838c510c5dea2 /drivers | |
| parent | 8be00d98f167b95fac8886d60f9942ef0c744445 (diff) | |
staging: brcm80211: smac: fix for 64 bit systems
A bug was introduced by the following commit (Sep 13):
staging: brcm80211: use endian annotated structures in brcmsmac
Result was that 64 bits systems will not be able to acquire an IP address.
Also the rmmod crashed. This has been fixed and retested on a Sparc64.
Reviewed-by: Pieter-Paul Giesberts <pieterpg@broadcom.com>
Reviewed-by: Alwin Beukers <alwin@broadcom.com>
Reviewed-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/staging/brcm80211/brcmsmac/mac80211_if.c | 4 | ||||
| -rw-r--r-- | drivers/staging/brcm80211/brcmsmac/ucode_loader.h | 4 |
2 files changed, 4 insertions, 4 deletions
diff --git a/drivers/staging/brcm80211/brcmsmac/mac80211_if.c b/drivers/staging/brcm80211/brcmsmac/mac80211_if.c index fa00ab31fab5..ac78052b4955 100644 --- a/drivers/staging/brcm80211/brcmsmac/mac80211_if.c +++ b/drivers/staging/brcm80211/brcmsmac/mac80211_if.c @@ -1606,7 +1606,7 @@ fail: * Precondition: Since this function is called in brcms_pci_probe() context, * no locking is required. */ -int brcms_ucode_init_uint(struct brcms_info *wl, u32 *data, u32 idx) +int brcms_ucode_init_uint(struct brcms_info *wl, size_t *n_bytes, u32 idx) { int i, entry; const u8 *pdata; @@ -1623,7 +1623,7 @@ int brcms_ucode_init_uint(struct brcms_info *wl, u32 *data, u32 idx) "ERROR: fw hdr len\n"); return -ENOMSG; } - *data = le32_to_cpu(*((__le32 *) pdata)); + *n_bytes = le32_to_cpu(*((__le32 *) pdata)); return 0; } } diff --git a/drivers/staging/brcm80211/brcmsmac/ucode_loader.h b/drivers/staging/brcm80211/brcmsmac/ucode_loader.h index 49d5b7e9a4ec..18750a814b4f 100644 --- a/drivers/staging/brcm80211/brcmsmac/ucode_loader.h +++ b/drivers/staging/brcm80211/brcmsmac/ucode_loader.h @@ -50,8 +50,8 @@ extern void brcms_ucode_data_free(struct brcms_ucode *ucode); extern int brcms_ucode_init_buf(struct brcms_info *wl, void **pbuf, unsigned int idx); -extern int brcms_ucode_init_uint(struct brcms_info *wl, unsigned *data, - unsigned int idx); +extern int brcms_ucode_init_uint(struct brcms_info *wl, size_t *n_bytes, + unsigned int idx); extern void brcms_ucode_free_buf(void *); extern int brcms_check_firmwares(struct brcms_info *wl); |