diff options
author | Benjamin Poirier <bpoirier@suse.com> | 2019-09-27 19:11:55 +0900 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2019-10-04 17:17:44 +0200 |
commit | d7618e38461e6a3f190d88fb941befd51b7c29b0 (patch) | |
tree | fe68530fecc59c73b24cf948b89cc7b5904b4d3f /drivers/staging/qlge/qlge.h | |
parent | 40115bbc40e2fd2de0e01ef2a28e0d09a1b5d0d1 (diff) |
staging: qlge: Fix irq masking in INTx mode
Tracing the driver operation reveals that the INTR_EN_EN bit (per-queue
interrupt control) does not immediately prevent rx completion interrupts
when the device is operating in INTx mode. This leads to interrupts being
raised while napi is scheduled/running. Those interrupts are ignored by
qlge_isr() and falsely reported as IRQ_NONE thanks to the irq_cnt scheme.
This in turn can cause frames to loiter in the receive queue until a later
frame leads to another rx interrupt that will schedule napi.
Use the INTR_EN_EI bit (master interrupt control) instead.
Signed-off-by: Benjamin Poirier <bpoirier@suse.com>
Link: https://lore.kernel.org/r/20190927101210.23856-2-bpoirier@suse.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/staging/qlge/qlge.h')
0 files changed, 0 insertions, 0 deletions