diff options
| author | Viresh Kumar <viresh.kumar@linaro.org> | 2016-01-11 11:29:04 +0530 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@google.com> | 2016-01-11 15:58:01 -0800 |
| commit | 8adf71d1b43aa1c449d22dd8e6f6c29957872a7f (patch) | |
| tree | 9b5172b89bfe7f0b966a04ef259282f3c3366fcc /drivers/staging/greybus/arche-platform.c | |
| parent | 73658f2a285dd8b53160355e619fcb59db3bb98a (diff) | |
greybus: arche-platform: Export GPIOs after populating APBs
Populating APBs operation can potentially fail and it would be better if
we export the GPIOs towards then end of the routine, so that we don't
need to unexport them on error cases.
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
Reviewed-by: Vaibhav Hiremath <vaibhav.hiremath@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@google.com>
Diffstat (limited to 'drivers/staging/greybus/arche-platform.c')
| -rw-r--r-- | drivers/staging/greybus/arche-platform.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/staging/greybus/arche-platform.c b/drivers/staging/greybus/arche-platform.c index 259473cd506d..93d90b2dc866 100644 --- a/drivers/staging/greybus/arche-platform.c +++ b/drivers/staging/greybus/arche-platform.c @@ -154,13 +154,13 @@ static int arche_platform_probe(struct platform_device *pdev) arche_pdata->num_apbs = of_get_child_count(np); dev_dbg(dev, "Number of APB's available - %d\n", arche_pdata->num_apbs); - export_gpios(arche_pdata); - /* probe all childs here */ ret = of_platform_populate(np, NULL, NULL, dev); if (ret) dev_err(dev, "no child node found\n"); + export_gpios(arche_pdata); + dev_info(dev, "Device registered successfully\n"); return ret; } |