diff options
author | Tetsuhiro Kohada <Kohada.Tetsuhiro@dc.MitsubishiElectric.co.jp> | 2020-02-28 17:40:36 +0900 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2020-03-04 07:46:34 +0100 |
commit | dbcf85e2728f1d2b36543ae1ed81217b5542589a (patch) | |
tree | 7112784c0ecf31ef7d05a048e704a652b86a8f6f /drivers/staging/exfat | |
parent | 2777313cf23451136f440d51fa80a6bb66133c63 (diff) |
staging: exfat: remove 'file creation modes'
The mode parameter in ffsCreateFile() and create_file() is redundant.
Remove it and definition.
Signed-off-by: Tetsuhiro Kohada <Kohada.Tetsuhiro@dc.MitsubishiElectric.co.jp>
Link: https://lore.kernel.org/r/20200228084037.15123-1-Kohada.Tetsuhiro@dc.MitsubishiElectric.co.jp
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/staging/exfat')
-rw-r--r-- | drivers/staging/exfat/exfat.h | 5 | ||||
-rw-r--r-- | drivers/staging/exfat/exfat_core.c | 6 | ||||
-rw-r--r-- | drivers/staging/exfat/exfat_super.c | 7 |
3 files changed, 7 insertions, 11 deletions
diff --git a/drivers/staging/exfat/exfat.h b/drivers/staging/exfat/exfat.h index f588538c67a8..c863d7566b57 100644 --- a/drivers/staging/exfat/exfat.h +++ b/drivers/staging/exfat/exfat.h @@ -200,9 +200,6 @@ static inline u16 get_row_index(u16 i) #define ATTR_EXTEND 0x000F #define ATTR_RWMASK 0x007E -/* file creation modes */ -#define FM_REGULAR 0x00 - #define NUM_UPCASE 2918 #ifdef __LITTLE_ENDIAN @@ -698,7 +695,7 @@ s32 exfat_mount(struct super_block *sb, struct pbr_sector_t *p_pbr); s32 create_dir(struct inode *inode, struct chain_t *p_dir, struct uni_name_t *p_uniname, struct file_id_t *fid); s32 create_file(struct inode *inode, struct chain_t *p_dir, - struct uni_name_t *p_uniname, u8 mode, struct file_id_t *fid); + struct uni_name_t *p_uniname, struct file_id_t *fid); void remove_file(struct inode *inode, struct chain_t *p_dir, s32 entry); s32 exfat_rename_file(struct inode *inode, struct chain_t *p_dir, s32 old_entry, struct uni_name_t *p_uniname, struct file_id_t *fid); diff --git a/drivers/staging/exfat/exfat_core.c b/drivers/staging/exfat/exfat_core.c index 941094b08dd9..ceaea1ba1a83 100644 --- a/drivers/staging/exfat/exfat_core.c +++ b/drivers/staging/exfat/exfat_core.c @@ -2172,7 +2172,7 @@ s32 create_dir(struct inode *inode, struct chain_t *p_dir, } s32 create_file(struct inode *inode, struct chain_t *p_dir, - struct uni_name_t *p_uniname, u8 mode, struct file_id_t *fid) + struct uni_name_t *p_uniname, struct file_id_t *fid) { s32 ret, dentry, num_entries; struct super_block *sb = inode->i_sb; @@ -2190,7 +2190,7 @@ s32 create_file(struct inode *inode, struct chain_t *p_dir, /* fill the directory entry information of the created file. * the first cluster is not determined yet. (0) */ - ret = exfat_init_dir_entry(sb, p_dir, dentry, TYPE_FILE | mode, + ret = exfat_init_dir_entry(sb, p_dir, dentry, TYPE_FILE, CLUSTER_32(0), 0); if (ret != 0) return ret; @@ -2204,7 +2204,7 @@ s32 create_file(struct inode *inode, struct chain_t *p_dir, fid->dir.flags = p_dir->flags; fid->entry = dentry; - fid->attr = ATTR_ARCHIVE | mode; + fid->attr = ATTR_ARCHIVE; fid->flags = 0x03; fid->size = 0; fid->start_clu = CLUSTER_32(~0); diff --git a/drivers/staging/exfat/exfat_super.c b/drivers/staging/exfat/exfat_super.c index 6f3b72eb999d..708398265828 100644 --- a/drivers/staging/exfat/exfat_super.c +++ b/drivers/staging/exfat/exfat_super.c @@ -617,8 +617,7 @@ out: return ret; } -static int ffsCreateFile(struct inode *inode, char *path, u8 mode, - struct file_id_t *fid) +static int ffsCreateFile(struct inode *inode, char *path, struct file_id_t *fid) { struct chain_t dir; struct uni_name_t uni_name; @@ -641,7 +640,7 @@ static int ffsCreateFile(struct inode *inode, char *path, u8 mode, fs_set_vol_flags(sb, VOL_DIRTY); /* create a new file */ - ret = create_file(inode, &dir, &uni_name, mode, fid); + ret = create_file(inode, &dir, &uni_name, fid); #ifndef CONFIG_STAGING_EXFAT_DELAYED_SYNC fs_sync(sb, true); @@ -1834,7 +1833,7 @@ static int exfat_create(struct inode *dir, struct dentry *dentry, umode_t mode, pr_debug("%s entered\n", __func__); - err = ffsCreateFile(dir, (u8 *)dentry->d_name.name, FM_REGULAR, &fid); + err = ffsCreateFile(dir, (u8 *)dentry->d_name.name, &fid); if (err) goto out; |