diff options
author | Jesper Juhl <jj@chaosbits.net> | 2012-03-23 01:08:34 +0100 |
---|---|---|
committer | Matthew Garrett <mjg@redhat.com> | 2012-03-26 15:45:32 -0400 |
commit | 41603e9783a24c8c7cce548c0819bdc9e46a585b (patch) | |
tree | d309d27fd11f922cb20cab809ac3db9096ff2377 /drivers/platform/x86/acer-wmi.c | |
parent | a979e2e2af7d5b4bb3b20f6a716c627bb23a6753 (diff) |
drivers/platform/x86/amilo-rfkill.c::amilo_rfkill_probe() avoid NULL deref
In drivers/platform/x86/amilo-rfkill.c::amilo_rfkill_probe() the call
to dmi_first_match() may fail and return NULL. If it does return NULL,
then we'll be dereferencing a NULL pointer in the rfkill_alloc() call
where we do 'system_id->driver_data' --> KABOOM!
Avoid that problem by testing for a NULL return value from
dmi_first_match() and bailing out if it fails.
I was a bit uncertain about what to return in the failure case. In the
end I settled for -ENXIO as the most logical error to return.
Signed-off-by: Jesper Juhl <jj@chaosbits.net>
Signed-off-by: Matthew Garrett <mjg@redhat.com>
Diffstat (limited to 'drivers/platform/x86/acer-wmi.c')
0 files changed, 0 insertions, 0 deletions