diff options
author | Gustavo A. R. Silva <gustavo@embeddedor.com> | 2020-02-11 14:53:56 -0600 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2020-02-16 18:33:00 -0800 |
commit | 1f4c51de3361f3d9223f7662b9567844e9fb7ca8 (patch) | |
tree | 4d4c628d7e223aed6d8eb8aec5330cb876dedb00 /drivers/net | |
parent | d71151a39c97d551378a441c089508b0bca48210 (diff) |
lib: objagg: Replace zero-length arrays with flexible-array member
The current codebase makes use of the zero-length array language
extension to the C90 standard, but the preferred mechanism to declare
variable-length types such as these ones is a flexible array member[1][2],
introduced in C99:
struct foo {
int stuff;
struct boo array[];
};
By making use of the mechanism above, we will get a compiler warning
in case the flexible array does not occur last in the structure, which
will help us prevent some kind of undefined behavior bugs from being
inadvertenly introduced[3] to the codebase from now on.
This issue was found with the help of Coccinelle.
[1] https://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html
[2] https://github.com/KSPP/linux/issues/21
[3] commit 76497732932f ("cxgb3/l2t: Fix undefined behaviour")
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Acked-by: Jiri Pirko <jiri@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net')
0 files changed, 0 insertions, 0 deletions