summaryrefslogtreecommitdiffstats
path: root/drivers/net/ipa/ipa_modem.c
diff options
context:
space:
mode:
authorAlex Elder <elder@linaro.org>2020-05-15 15:07:31 -0500
committerDavid S. Miller <davem@davemloft.net>2020-05-16 16:47:19 -0700
commit195ef57f870070cb02f2f3b99a63d69e8e8f798e (patch)
tree3c6810b70db8a6f32da3d0ff199785135fcc921c /drivers/net/ipa/ipa_modem.c
parenta4f48458ca1c02eeedf914ef6a892e047d6b65cc (diff)
net: ipa: do not clear interrupt in gsi_channel_start()
In gsi_channel_start() there is harmless-looking comment "Clear the channel's event ring interrupt in case it's pending". The intent was to avoid getting spurious interrupts when first bringing up a channel. However we now use channel stop/start to implement suspend and resume, and an interrupt pending at the time we resume is actually something we don't want to ignore. The very first time we bring up the channel we do not expect an interrupt to be pending, and even if it were, the effect would simply be to schedule NAPI on that channel, which would find nothing to do, which is not a problem. Stop clearing any pending IEOB interrupt in gsi_channel_start(). That leaves one caller of the trivial function gsi_isr_ieob_clear(). Get rid of that function and just open-code it in gsi_isr_ieob() instead. This fixes a problem where suspend/resume IPA v4.2 would get stuck when resuming after a suspend. Signed-off-by: Alex Elder <elder@linaro.org> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ipa/ipa_modem.c')
0 files changed, 0 insertions, 0 deletions