summaryrefslogtreecommitdiffstats
path: root/drivers/mtd/nand/raw/diskonchip.c
diff options
context:
space:
mode:
authorMiquel Raynal <miquel.raynal@bootlin.com>2020-11-13 13:34:11 +0100
committerMiquel Raynal <miquel.raynal@bootlin.com>2020-11-19 21:52:32 +0100
commit3500bd7035ee6df2a465f37439d3cb9e00d2f66a (patch)
tree5825de20f862d1c45dc2220214e619329c20ba5e /drivers/mtd/nand/raw/diskonchip.c
parent58e111002887ad5f0b665685aac3d4c3bc3768db (diff)
mtd: rawnand: davinci: Move the ECC initialization to ->attach_chip()
The probe function is only supposed to initialize the controller hardware but not the ECC engine. Indeed, we don't know anything about the NAND chip(s) at this stage. Let's move the logic initializing the ECC engine, even pretty simple, to the ->attach_chip() hook which gets called during nand_scan() routine, after the NAND chip discovery. As the previously mentioned logic is supposed to parse the DT for us, it is likely that the chip->ecc.* entries be overwritten. So let's avoid this by moving these lines to ->attach_chip(). Fixes: d7157ff49a5b ("mtd: rawnand: Use the ECC framework user input parsing bits") Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com> Cc: Bartosz Golaszewski <bgolaszewski@baylibre.com> Link: https://lore.kernel.org/linux-mtd/20201113123424.32233-7-miquel.raynal@bootlin.com
Diffstat (limited to 'drivers/mtd/nand/raw/diskonchip.c')
0 files changed, 0 insertions, 0 deletions