summaryrefslogtreecommitdiffstats
path: root/arch/blackfin
diff options
context:
space:
mode:
authorRussell King <rmk+kernel@arm.linux.org.uk>2014-04-06 15:20:03 -0700
committerBryan Wu <cooloney@gmail.com>2014-04-07 14:41:50 -0700
commit392369019eb96e914234ea21eda806cb51a1073e (patch)
tree7306c836d06f08d962251e1166875f855e3d2952 /arch/blackfin
parent0016db26c093798632ea741402215a31af447704 (diff)
leds: leds-pwm: properly clean up after probe failure
When probing with DT, we add each LED one at a time. If we find a LED without a PWM device (because it is not available yet) we fail the initialisation, unregister previous LEDs, and then by way of managed resources, we free the structure. The problem with this is we may have a scheduled and active work_struct in this structure, and this results in a nasty kernel oops. We need to cancel this work_struct properly upon cleanup - and the cleanup we require is the same cleanup as we do when the LED platform device is removed. Rather than writing this same code three times, move it into a separate function and use it in all three places. Fixes: c971ff185f64 ("leds: leds-pwm: Defer led_pwm_set() if PWM can sleep") Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk> Signed-off-by: Bryan Wu <cooloney@gmail.com>
Diffstat (limited to 'arch/blackfin')
0 files changed, 0 insertions, 0 deletions