diff options
author | Pavel Begunkov <asml.silence@gmail.com> | 2020-01-22 23:09:35 +0300 |
---|---|---|
committer | Jens Axboe <axboe@kernel.dk> | 2020-01-22 13:57:46 -0700 |
commit | 1118591ab883f46df4ab614cc976bc4c8e04a464 (patch) | |
tree | 50adb45f27ed9fd54e54925a662d09f467f10ce0 | |
parent | 0463b6c58e557118d602b2f225fa3bbe9b6f3560 (diff) |
io_uring: prep req when do IOSQE_ASYNC
Whenever IOSQE_ASYNC is set, requests will be punted to async without
getting into io_issue_req() and without proper preparation done (e.g.
io_req_defer_prep()). Hence they will be left uninitialised.
Prepare them before punting.
Signed-off-by: Pavel Begunkov <asml.silence@gmail.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
-rw-r--r-- | fs/io_uring.c | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/fs/io_uring.c b/fs/io_uring.c index 09503d1e9e45..cdbc711ae5fd 100644 --- a/fs/io_uring.c +++ b/fs/io_uring.c @@ -4558,11 +4558,15 @@ static void io_queue_sqe(struct io_kiocb *req, const struct io_uring_sqe *sqe) ret = io_req_defer(req, sqe); if (ret) { if (ret != -EIOCBQUEUED) { +fail_req: io_cqring_add_event(req, ret); req_set_fail_links(req); io_double_put_req(req); } } else if (req->flags & REQ_F_FORCE_ASYNC) { + ret = io_req_defer_prep(req, sqe); + if (unlikely(ret < 0)) + goto fail_req; /* * Never try inline submit of IOSQE_ASYNC is set, go straight * to async execution. |